Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rails 6.1 support in doc generation #702

Merged
merged 5 commits into from Jun 29, 2021
Merged

Add Rails 6.1 support in doc generation #702

merged 5 commits into from Jun 29, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jan 8, 2021

It looks like the changes in rails/rails#35093 broke the use of ActionView::Base.new which should make this library Rails 6.1 compatible.

@vitiokss
Copy link

vitiokss commented Jun 1, 2021

@ofedoren would you mind taking look at this?

@vitiokss
Copy link

vitiokss commented Jun 1, 2021

@Pajk

@voxik
Copy link
Contributor

voxik commented Jun 11, 2021

I'm going to apply this PR to fix the package in Fedora.

Otherwise, I'd suggest to squash the "remove formatting changes" commit or make the formatting changes as separate commit (of course without removing them later).

@arielcebulig
Copy link

Up for this fixing, thnk you braaahh

@arielcebulig
Copy link

you can try this pr to your Gemfile by adding

gem 'apipie-rails', :github => "andrew-newell/apipie-rails", branch: :'newell/fix_rails_6.1_doc_generation'

@ghost
Copy link
Author

ghost commented Jun 29, 2021

Otherwise, I'd suggest to squash the "remove formatting changes" commit or make the formatting changes as separate commit (of course without removing them later).

Forgive my ignorance, but if this PR is squash merged, what's the difference? @voxik

Copy link
Contributor

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi all, sorry for ignoring PRs, I don't have much time to follow here, but ping rather me than others :)

I'm going to merge this, thanks, @andrew-newell!

@ofedoren ofedoren merged commit a4d0b34 into Apipie:master Jun 29, 2021
@vitiokss
Copy link

vitiokss commented Jul 7, 2021

@ofedoren can you also release a new version of the lib?

@ofedoren
Copy link
Contributor

ofedoren commented Jul 8, 2021

@vitiokss, sure. I also wanted to add a rel-eng playbook, so it helps with the future releases; probably this/next week. IF I don't release, please ping me again, but angrily.

@vitiokss
Copy link

@ofedoren any news? :)

@ofedoren
Copy link
Contributor

@ofedoren any news? :)

Finally there is 0.5.19 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants