Separate nested resource name #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PanosCodes
changed the title
PanosCodes
force-pushed
the
separate-nested-resource-names
branch
from
91f9f1b
to
a622122
Compare
The expected behavior when `Apipie.configuration.namespaced_resources?` is true is for a nested resource like `V1::Users::TweetsController` to return `v1-users-tweets` however it was returning `v1userstweets`
- Rename the `resource_name` argument to `id`, it can be missleading - Create `name` method return a human readable resource name depending on the `@id`. Example if id is `some-nested-resource` `#name` will return `Some::Nested::Resource`
PanosCodes
force-pushed
the
separate-nested-resource-names
branch
from
a622122
to
fb0a537
Compare
mathieujobin
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes #455
How
Updates
get_resource_nameto return a-seperated resource id.The expected behavior when
Apipie.configuration.namespaced_resources?is true is for a nested resource likeV1::Users::TweetsControllerto returnv1-users-tweetshowever it was returningv1userstweetsUses the above dash separated format to return a readable nested resource name. Example if id is
some-nested-resource#namewill returnSome::Nested::Resourcethat is later used in views.