-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added operating system version check for build. #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think 16.04 can compile, please allow any Ubuntu for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Alternatively, we can force the build to occur inside the corresponding docker environment (as encouraged in the main README.md file). |
[build][ApolloAuto#26][docker] Introduce of rocm_docker for AMD GPU target (Step 1)
…D Docker (on behalf of alexpetersburg) The change by alexpetersburg In order not to build Apollo AMD Docker with the installed ROCm libraries every time, we need to upload it to a public Docker Hub. Since we don't have access to the Apolloauto/apollo [https://hub.docker.com/r/apolloauto/apollo] repository yet, the image was temporarily uploaded to luxoftavnefedov/apollo_mirror [https://hub.docker.com/r/luxoftavnefedov/apollo_mirror] Hub repo, and was specified in `APOLLO_MIRROR_REPO` variable of dev_start.sh. The version of the image `VERSION_ROCM_X86_64` was also updated. [ToDo] To upload AMD Docker to https://hub.docker.com/r/apolloauto/apollo and start using it from there
[AMD][build][docker][ApolloAuto#26][temporary] Dev image of Apollo AMD Docker (on behalf of alexpetersburg)
+ Change AMD base docker image in `build_docker.sh`. Current base image: `rocm/dev-ubuntu-18.04:5.1.1-complete` + Build dev image and pull to temlate dockerhub + Change dev image tag in `dev_start.sh` [Tests] The new image did not affect the AMD configuration build
[AMD][build][docker][ApolloAuto#26] Dev image with ROCm v5.1.1
[AMD][ApolloAuto#26][ApolloAuto#82][ApolloAuto#86][build][docker][fix] Add symlinks creation
No description provided.