Skip to content

Commit

Permalink
Fix IDE0011 warning (#2085)
Browse files Browse the repository at this point in the history
Fix IDE0011 warnings.
  • Loading branch information
iamdmitrij committed Apr 29, 2024
1 parent 6bf7fc1 commit 4ba2086
Show file tree
Hide file tree
Showing 54 changed files with 1,087 additions and 2 deletions.
8 changes: 8 additions & 0 deletions src/Polly/AsyncPolicy.ContextAndKeys.cs
Expand Up @@ -10,7 +10,9 @@ public abstract partial class AsyncPolicy
public AsyncPolicy WithPolicyKey(string policyKey)
{
if (policyKeyInternal != null)
{
throw PolicyKeyMustBeImmutableException(nameof(policyKey));
}

policyKeyInternal = policyKey;
return this;
Expand All @@ -24,7 +26,9 @@ public AsyncPolicy WithPolicyKey(string policyKey)
IAsyncPolicy IAsyncPolicy.WithPolicyKey(string policyKey)
{
if (policyKeyInternal != null)
{
throw PolicyKeyMustBeImmutableException(nameof(policyKey));
}

policyKeyInternal = policyKey;
return this;
Expand All @@ -41,7 +45,9 @@ public abstract partial class AsyncPolicy<TResult>
public AsyncPolicy<TResult> WithPolicyKey(string policyKey)
{
if (policyKeyInternal != null)
{
throw PolicyKeyMustBeImmutableException(nameof(policyKey));
}

policyKeyInternal = policyKey;
return this;
Expand All @@ -55,7 +61,9 @@ public AsyncPolicy<TResult> WithPolicyKey(string policyKey)
IAsyncPolicy<TResult> IAsyncPolicy<TResult>.WithPolicyKey(string policyKey)
{
if (policyKeyInternal != null)
{
throw PolicyKeyMustBeImmutableException(nameof(policyKey));
}

policyKeyInternal = policyKey;
return this;
Expand Down
8 changes: 8 additions & 0 deletions src/Polly/AsyncPolicy.ExecuteOverloads.cs
Expand Up @@ -94,7 +94,9 @@ public abstract partial class AsyncPolicy : PolicyBase, IAsyncPolicy
public async Task ExecuteAsync(Func<Context, CancellationToken, Task> action, Context context, CancellationToken cancellationToken, bool continueOnCapturedContext)
{
if (context == null)
{
throw new ArgumentNullException(nameof(context));
}

SetPolicyContext(context, out string priorPolicyWrapKey, out string priorPolicyKey);

Expand Down Expand Up @@ -218,7 +220,9 @@ public async Task ExecuteAsync(Func<Context, CancellationToken, Task> action, Co
public async Task<TResult> ExecuteAsync<TResult>(Func<Context, CancellationToken, Task<TResult>> action, Context context, CancellationToken cancellationToken, bool continueOnCapturedContext)
{
if (context == null)
{
throw new ArgumentNullException(nameof(context));
}

SetPolicyContext(context, out string priorPolicyWrapKey, out string priorPolicyKey);

Expand Down Expand Up @@ -335,7 +339,9 @@ public async Task<TResult> ExecuteAsync<TResult>(Func<Context, CancellationToken
public async Task<PolicyResult> ExecuteAndCaptureAsync(Func<Context, CancellationToken, Task> action, Context context, CancellationToken cancellationToken, bool continueOnCapturedContext)
{
if (context == null)
{
throw new ArgumentNullException(nameof(context));
}

try
{
Expand Down Expand Up @@ -460,7 +466,9 @@ public async Task<PolicyResult> ExecuteAndCaptureAsync(Func<Context, Cancellatio
public async Task<PolicyResult<TResult>> ExecuteAndCaptureAsync<TResult>(Func<Context, CancellationToken, Task<TResult>> action, Context context, CancellationToken cancellationToken, bool continueOnCapturedContext)
{
if (context == null)
{
throw new ArgumentNullException(nameof(context));
}

try
{
Expand Down
4 changes: 4 additions & 0 deletions src/Polly/AsyncPolicy.TResult.ExecuteOverloads.cs
Expand Up @@ -103,7 +103,9 @@ public abstract partial class AsyncPolicy<TResult> : IAsyncPolicy<TResult>
public async Task<TResult> ExecuteAsync(Func<Context, CancellationToken, Task<TResult>> action, Context context, CancellationToken cancellationToken, bool continueOnCapturedContext)
{
if (context == null)
{
throw new ArgumentNullException(nameof(context));
}

SetPolicyContext(context, out string priorPolicyWrapKey, out string priorPolicyKey);

Expand Down Expand Up @@ -222,7 +224,9 @@ public async Task<TResult> ExecuteAsync(Func<Context, CancellationToken, Task<TR
public async Task<PolicyResult<TResult>> ExecuteAndCaptureAsync(Func<Context, CancellationToken, Task<TResult>> action, Context context, CancellationToken cancellationToken, bool continueOnCapturedContext)
{
if (context == null)
{
throw new ArgumentNullException(nameof(context));
}

try
{
Expand Down
8 changes: 8 additions & 0 deletions src/Polly/Bulkhead/AsyncBulkheadSyntax.cs
Expand Up @@ -60,11 +60,19 @@ public static AsyncBulkheadPolicy BulkheadAsync(int maxParallelization, int maxQ
Func<Context, Task> onBulkheadRejectedAsync)
{
if (maxParallelization <= 0)
{
throw new ArgumentOutOfRangeException(nameof(maxParallelization), "Value must be greater than zero.");
}

if (maxQueuingActions < 0)
{
throw new ArgumentOutOfRangeException(nameof(maxQueuingActions), "Value must be greater than or equal to zero.");
}

if (onBulkheadRejectedAsync == null)
{
throw new ArgumentNullException(nameof(onBulkheadRejectedAsync));
}

return new AsyncBulkheadPolicy(
maxParallelization,
Expand Down
8 changes: 8 additions & 0 deletions src/Polly/Bulkhead/AsyncBulkheadTResultSyntax.cs
Expand Up @@ -60,11 +60,19 @@ public static AsyncBulkheadPolicy<TResult> BulkheadAsync<TResult>(int maxParalle
public static AsyncBulkheadPolicy<TResult> BulkheadAsync<TResult>(int maxParallelization, int maxQueuingActions, Func<Context, Task> onBulkheadRejectedAsync)
{
if (maxParallelization <= 0)
{
throw new ArgumentOutOfRangeException(nameof(maxParallelization), "Value must be greater than zero.");
}

if (maxQueuingActions < 0)
{
throw new ArgumentOutOfRangeException(nameof(maxQueuingActions), "Value must be greater than or equal to zero.");
}

if (onBulkheadRejectedAsync == null)
{
throw new ArgumentNullException(nameof(onBulkheadRejectedAsync));
}

return new AsyncBulkheadPolicy<TResult>(
maxParallelization,
Expand Down
8 changes: 8 additions & 0 deletions src/Polly/Bulkhead/BulkheadSyntax.cs
Expand Up @@ -57,11 +57,19 @@ public static BulkheadPolicy Bulkhead(int maxParallelization, int maxQueuingActi
public static BulkheadPolicy Bulkhead(int maxParallelization, int maxQueuingActions, Action<Context> onBulkheadRejected)
{
if (maxParallelization <= 0)
{
throw new ArgumentOutOfRangeException(nameof(maxParallelization), "Value must be greater than zero.");
}

if (maxQueuingActions < 0)
{
throw new ArgumentOutOfRangeException(nameof(maxQueuingActions), "Value must be greater than or equal to zero.");
}

if (onBulkheadRejected == null)
{
throw new ArgumentNullException(nameof(onBulkheadRejected));
}

return new BulkheadPolicy(
maxParallelization,
Expand Down
8 changes: 8 additions & 0 deletions src/Polly/Bulkhead/BulkheadTResultSyntax.cs
Expand Up @@ -61,11 +61,19 @@ public static BulkheadPolicy<TResult> Bulkhead<TResult>(int maxParallelization,
public static BulkheadPolicy<TResult> Bulkhead<TResult>(int maxParallelization, int maxQueuingActions, Action<Context> onBulkheadRejected)
{
if (maxParallelization <= 0)
{
throw new ArgumentOutOfRangeException(nameof(maxParallelization), "Value must be greater than zero.");
}

if (maxQueuingActions < 0)
{
throw new ArgumentOutOfRangeException(nameof(maxQueuingActions), "Value must be greater than or equal to zero.");
}

if (onBulkheadRejected == null)
{
throw new ArgumentNullException(nameof(onBulkheadRejected));
}

return new BulkheadPolicy<TResult>(
maxParallelization,
Expand Down
32 changes: 32 additions & 0 deletions src/Polly/Caching/AsyncCacheSyntax.cs
Expand Up @@ -65,11 +65,19 @@ public partial class Policy
public static AsyncCachePolicy CacheAsync(IAsyncCacheProvider cacheProvider, ITtlStrategy ttlStrategy, ICacheKeyStrategy cacheKeyStrategy, Action<Context, string, Exception>? onCacheError = null)
{
if (cacheProvider == null)
{
throw new ArgumentNullException(nameof(cacheProvider));
}

if (ttlStrategy == null)
{
throw new ArgumentNullException(nameof(ttlStrategy));
}

if (cacheKeyStrategy == null)
{
throw new ArgumentNullException(nameof(cacheKeyStrategy));
}

Action<Context, string> emptyDelegate = (_, _) => { };

Expand Down Expand Up @@ -109,11 +117,19 @@ public static AsyncCachePolicy CacheAsync(IAsyncCacheProvider cacheProvider, ITt
public static AsyncCachePolicy CacheAsync(IAsyncCacheProvider cacheProvider, ITtlStrategy ttlStrategy, Func<Context, string> cacheKeyStrategy, Action<Context, string, Exception>? onCacheError = null)
{
if (cacheProvider == null)
{
throw new ArgumentNullException(nameof(cacheProvider));
}

if (ttlStrategy == null)
{
throw new ArgumentNullException(nameof(ttlStrategy));
}

if (cacheKeyStrategy == null)
{
throw new ArgumentNullException(nameof(cacheKeyStrategy));
}

Action<Context, string> emptyDelegate = (_, _) => { };

Expand Down Expand Up @@ -303,18 +319,34 @@ public static AsyncCachePolicy CacheAsync(IAsyncCacheProvider cacheProvider, ITt
Action<Context, string, Exception>? onCachePutError)
{
if (cacheProvider == null)
{
throw new ArgumentNullException(nameof(cacheProvider));
}

if (ttlStrategy == null)
{
throw new ArgumentNullException(nameof(ttlStrategy));
}

if (cacheKeyStrategy == null)
{
throw new ArgumentNullException(nameof(cacheKeyStrategy));
}

if (onCacheGet == null)
{
throw new ArgumentNullException(nameof(onCacheGet));
}

if (onCacheMiss == null)
{
throw new ArgumentNullException(nameof(onCacheMiss));
}

if (onCachePut == null)
{
throw new ArgumentNullException(nameof(onCachePut));
}

return new AsyncCachePolicy(cacheProvider, ttlStrategy, cacheKeyStrategy, onCacheGet, onCacheMiss, onCachePut, onCacheGetError, onCachePutError);
}
Expand Down

0 comments on commit 4ba2086

Please sign in to comment.