Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: README has improper grammar, which makes the meaning unclear. #2098

Closed
digimunk opened this issue May 7, 2024 · 2 comments · Fixed by #2099
Closed

[Bug]: README has improper grammar, which makes the meaning unclear. #2098

digimunk opened this issue May 7, 2024 · 2 comments · Fixed by #2099
Assignees

Comments

@digimunk
Copy link

digimunk commented May 7, 2024

Describe the bug

"Unlike reactive strategies, proactive strategies do not focus on handling errors by the callbacks might throw or return. They can make pro-active decisions to cancel or reject the execution of callbacks."

What does "...by the callbacks might throw or return" mean?

The first sentence has "proactive," and the second has "pro-active." Please be consistent.

Expected behavior

Good and consistent grammar

Actual behavior

Poor and inconsistent grammar

Steps to reproduce

View the README

Exception(s) (if any)

No response

Polly version

No response

.NET Version

No response

Anything else?

No response

@martincostello
Copy link
Member

The first one looks like it should say "but".

Consistency is good, we must have missed that in review.

A PR to apply those changes is welcome.

@martincostello
Copy link
Member

Also note that some of our contributors don't speak English as their native language, so things can slip in that might get overlooked during reviews.

martincostello added a commit to martincostello/Polly that referenced this issue May 8, 2024
- Fix typo.
- Adjust table formatting.

Resolves App-vNext#2098.
@martincostello martincostello self-assigned this May 8, 2024
martincostello added a commit that referenced this issue May 8, 2024
- Fix typo.
- Adjust table formatting.

Resolves #2098.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants