Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running async actions on captured synchronization context #49

Closed
yevhen opened this issue Oct 27, 2015 · 3 comments
Closed

Running async actions on captured synchronization context #49

yevhen opened this issue Oct 27, 2015 · 3 comments
Milestone

Comments

@yevhen
Copy link
Contributor

yevhen commented Oct 27, 2015

Runnng Polly inside MS Orleans grain is not possible, since Orleans uses custom TaskScheduler and due to automatically added ConfigureAwait(false) action escapes it and runs on different thread, thus breaking single-threaded guarantee provided by Orleans.

Is that possible to add an overload for RetryAsync\WaitRetryAsync that will allow to control that behavior?

P.S. I'll be happy to send a PR but I have no idea what feature/project type my VS15 installation is missing, that I cannot load Polly.Shared projects. It tell me that The imported project "C:\Program Files (x86)\MSBuild\Microsoft\WindowsXaml\v14.0\8.1\Microsoft.Windows.UI.Xaml.CSharp.targets" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk. C:\Program Files (x86)\MSBuild\Microsoft\WindowsXaml\v14.0\Microsoft.Windows.UI.Xaml.CSharp.targets 😟

Is that ExpressionDesigner that need to be installed?

@johnkattenhorn
Copy link

Great catch - I'd never had figure this out in our project :-) I wonder if missing project type might be Xamarin Shared ?

@yevhen
Copy link
Contributor Author

yevhen commented Nov 3, 2015

I've figured out that I don't have Windows Phone SDK installed. Done that.

@michael-wolfenden will you accept PR that fixes aforementioned problems? We can discuss api changes before I even try or I can proceed with PR, so there will be something eligible for further discussion?

Sketching that, I think it could be implemented without any breaking changes.

@michael-wolfenden
Copy link
Contributor

Sure thing @yevhen, send through the pull request and I'll check it out

@joelhulen joelhulen added this to the 3.0 milestone Dec 3, 2015
joelhulen added a commit that referenced this issue Dec 30, 2015
Async sleep + continue on captured ctx. Fixes #49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants