Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hedging being cancelled too early #1340

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Fix hedging being cancelled too early #1340

merged 1 commit into from
Jun 22, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jun 22, 2023

Details on the issue fix or feature implementation

Hedging strategy should respect the original cancellation token otherwise inner strategy that replaces the cancellation token (TimeoutStrategy) can temporarily replace it and hedging will start accepting it. This could cause early hedging cancellation.

Added a test that demonstrates the issue.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jun 22, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jun 22, 2023
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #1340 (7f98d79) into main (18171df) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1340   +/-   ##
=======================================
  Coverage   83.54%   83.54%           
=======================================
  Files         270      270           
  Lines        6374     6374           
  Branches     1003     1003           
=======================================
  Hits         5325     5325           
  Misses        840      840           
  Partials      209      209           
Flag Coverage Δ
linux 83.54% <100.00%> (ø)
macos 83.54% <100.00%> (ø)
windows 83.54% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/Polly.Core/Hedging/HedgingResilienceStrategy.cs 100.00% <100.00%> (ø)

@martintmk martintmk merged commit 2167ed3 into main Jun 22, 2023
13 checks passed
@martintmk martintmk deleted the mtomka/fix-hedging branch June 22, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants