Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use var #1953

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Use var #1953

merged 1 commit into from
Feb 5, 2024

Conversation

martincostello
Copy link
Member

Some more var usage missed from #1950.

Some more var usage missed from App-vNext#1950.
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e937886) 85.91% compared to head (d6fa45f) 85.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1953   +/-   ##
=======================================
  Coverage   85.91%   85.91%           
=======================================
  Files         312      312           
  Lines        6654     6654           
  Branches     1057     1057           
=======================================
  Hits         5717     5717           
  Misses        540      540           
  Partials      397      397           
Flag Coverage Δ
linux 85.91% <ø> (ø)
macos 85.91% <ø> (ø)
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gintsk
Copy link
Contributor

gintsk commented Feb 5, 2024

Maybe it makes sense to use consistent variable naming within Polly.Specs ?
Changing these variations var tokenSource = new CancellationTokenSource(), var cts = new CancellationTokenSource(), var cancellationSource = new CancellationTokenSource()
to
var cancellationTokenSource = new CancellationTokenSource()

@martincostello
Copy link
Member Author

I considered that, but some also have custom names and it was just a quick drive-by change while I was preparing the next release, so I'm going to leave them as they are for the time being.

@martincostello martincostello merged commit 35ba8a3 into App-vNext:main Feb 5, 2024
14 checks passed
@martincostello martincostello deleted the use-var branch February 5, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants