Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New cache policy syntax #754

Closed

Conversation

eugbaranov
Copy link

@eugbaranov eugbaranov commented Feb 14, 2020

I've been experimenting with a new syntax for cache policies.

@reisenberger is that what you had in mind or something more radical?

@reisenberger
Copy link
Member

Thanks @eugbaranov , I'll take a look!

@eugbaranov eugbaranov force-pushed the new-cache-policy-syntax branch 2 times, most recently from 4dda044 to 581be9c Compare February 14, 2020 23:51
@reisenberger
Copy link
Member

@eugbaranov Thanks for sharing this! 👍 The plan for Polly v8 syntax is indeed quite like that (introduction of XOptions or XConfiguration class), but one step more: a policy would be configured by passing in an Action<XConfiguration>, as shown in this early sketch; a fluent builder style.

This syntax style has already been implemented for Simmy, by @vany0114 and myself. You can see the exact changes from old-style syntax, in this commit. Usage is as shown in the Simmy ReadMe.

Hoping to publish a more formal proposal and embark this work in the next 4 weeks (depending other commitments). Once we are underway, contributions to converting the policies over would be very welcome!

@martincostello martincostello changed the base branch from v721-or-v730 to v722-or-v730 January 23, 2021 14:35
@martincostello martincostello changed the base branch from v722-or-v730 to v723-or-v730 April 11, 2021 16:36
@martincostello martincostello changed the base branch from v723-or-v730 to v731-or-v740 January 17, 2022 13:28
@martincostello martincostello changed the base branch from v731-or-v740 to v724-or-v730 January 17, 2022 16:57
@martincostello
Copy link
Member

Closing due to inactivity.

Please open a new pull request if you would like to continue with a proposal for this change which we could consider for a v8 of Polly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants