Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix clippy linting errors and warnings #639

Merged
merged 1 commit into from
Jun 23, 2024
Merged

chore: fix clippy linting errors and warnings #639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/client-api/src/http_billing.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ impl Client {
("recurring_interval", recurring_interval.as_str()),
(
"workspace_subscription_plan",
&workspace_subscription_plan.as_str(),
workspace_subscription_plan.as_str(),
),
("success_url", success_url),
])
Expand Down
3 changes: 0 additions & 3 deletions services/appflowy-collaborate/src/group/broadcast.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,6 @@ impl CollabBroadcast {
Stream: StreamExt<Item = MessageByObjectId> + Send + Sync + Unpin + 'static,
<Sink as futures_util::Sink<CollabMessage>>::Error: std::error::Error + Send + Sync,
{
let cloned_origin = subscriber_origin.clone();
let sink_stop_tx = {
let mut sink = sink.clone();
let (stop_tx, mut stop_rx) = tokio::sync::mpsc::channel::<()>(1);
Expand Down Expand Up @@ -266,7 +265,6 @@ impl CollabBroadcast {
};

Subscription {
origin: cloned_origin,
sink_stop_tx: Some(sink_stop_tx),
stream_stop_tx: Some(stream_stop_tx),
}
Expand Down Expand Up @@ -540,7 +538,6 @@ fn ack_code_from_error(error: &RTProtocolError) -> AckCode {
/// connection error or closed connection).
#[derive(Debug)]
pub struct Subscription {
pub origin: CollabOrigin,
sink_stop_tx: Option<tokio::sync::mpsc::Sender<()>>,
stream_stop_tx: Option<tokio::sync::mpsc::Sender<()>>,
}
Expand Down
1 change: 0 additions & 1 deletion services/appflowy-collaborate/src/group/cmd.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ where
{
pub group_manager: Arc<GroupManager<S, AC>>,
pub msg_router_by_user: Arc<DashMap<RealtimeUser, ClientMessageRouter>>,
pub access_control: Arc<AC>,
pub recv: Option<GroupCommandReceiver>,
}

Expand Down
4 changes: 0 additions & 4 deletions services/appflowy-collaborate/src/rt_server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ pub struct CollaborationServer<S, AC> {
group_manager: Arc<GroupManager<S, AC>>,
connect_state: ConnectState,
group_sender_by_object_id: Arc<DashMap<String, GroupCommandSender>>,
access_control: Arc<AC>,
storage: Arc<S>,
#[allow(dead_code)]
metrics: Arc<CollabRealtimeMetrics>,
Expand Down Expand Up @@ -82,7 +81,6 @@ where
group_manager,
connect_state,
group_sender_by_object_id,
access_control,
metrics,
metrics_calculate,
})
Expand Down Expand Up @@ -168,7 +166,6 @@ where
let group_sender_by_object_id = self.group_sender_by_object_id.clone();
let client_msg_router_by_user = self.connect_state.client_message_routers.clone();
let group_manager = self.group_manager.clone();
let access_control = self.access_control.clone();

Box::pin(async move {
for (object_id, collab_messages) in message_by_oid {
Expand All @@ -186,7 +183,6 @@ where
let runner = GroupCommandRunner {
group_manager: group_manager.clone(),
msg_router_by_user: client_msg_router_by_user.clone(),
access_control: access_control.clone(),
recv: Some(recv),
};

Expand Down
Loading