Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add kanban shortcuts #5270

Merged
merged 28 commits into from
May 10, 2024
Merged

feat: add kanban shortcuts #5270

merged 28 commits into from
May 10, 2024

Conversation

richardshiue
Copy link
Collaborator

@richardshiue richardshiue commented May 6, 2024 •
edited

resolves #4995
resolves #2856
resolves #5283
resolves #3249

Feature Preview

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

@richardshiue richardshiue requested a review from Xazin May 6, 2024 07:23
@richardshiue richardshiue added new feature New feature or request v0.5.8 labels May 6, 2024
Xazin
Xazin reviewed May 6, 2024
View reviewed changes
Copy link
Collaborator

@Xazin Xazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Should pressing on "Rename" for any card reset the focus?
  • What should happen with focus on dragging a card?
  • Should NumpadEnter have same behavior as Enter, if yes we can consolidate the shortcut activator into a reusable method.
  • Should we open an issue for the lasso feature as well?
  • Other than the delete shortcut, should we also enable backspace for deletion? Eg. I don't have a delete button on my keyboard (MacOS QWERTY Danish/Nordic) .. Yes it's very saddening 😂

...tend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_focus_scope.dart Outdated Show resolved Hide resolved
...tend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_focus_scope.dart Show resolved Hide resolved
...tend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_focus_scope.dart Show resolved Hide resolved
...tend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_focus_scope.dart Outdated Show resolved Hide resolved
frontend/appflowy_flutter/test/bloc_test/board_test/create_card_test.dart Outdated Show resolved Hide resolved
@richardshiue richardshiue force-pushed the feat/kanban-shortcuts branch 2 times, most recently from 6e76b04 to 41fe928 Compare May 7, 2024 06:05
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024 •
edited

🥷 Ninja i18n – 🎉 Translations have been successfully updated

@richardshiue richardshiue force-pushed the feat/kanban-shortcuts branch 2 times, most recently from 26f3738 to d66da24 Compare May 8, 2024 12:17
@richardshiue richardshiue added the kanban board features related to the board-view database label May 9, 2024
@richardshiue richardshiue merged commit a490f34 into AppFlowy-IO:main May 10, 2024
14 of 15 checks passed
@richardshiue richardshiue deleted the feat/kanban-shortcuts branch May 10, 2024 02:02
zoli added a commit to zoli/AppFlowy that referenced this pull request May 11, 2024
@zoli
style: merge branch 'main' into feat/group-condition-2
87c53a8 
* main: (30 commits)
  feat: workspace settings page (AppFlowy-IO#5225)
  fix: kanban board card text input inconsistency (AppFlowy-IO#5307)
  feat: support scale up/down the app (AppFlowy-IO#5300)
  fix: android navigation bar issues (AppFlowy-IO#5294)
  feat: add kanban shortcuts (AppFlowy-IO#5270)
  chore: use patch to fix version issue (AppFlowy-IO#5291)
  refactor: mobile view page (AppFlowy-IO#5288)
  fix: database row page breadcrumbs on smaller screens (AppFlowy-IO#5289)
  chore: translate english to traditional chinese (AppFlowy-IO#5278)
  chore: update translations with Fink 🐦 (AppFlowy-IO#5249)
  feat: support system default font family on desktop (AppFlowy-IO#5279)
  fix: ws connect with invalid token (AppFlowy-IO#5282)
  chore: disable ai summary (AppFlowy-IO#5277)
  fix: color selection compatible with older versions (AppFlowy-IO#5276)
  chore: bump client api (AppFlowy-IO#5275)
  fix: assert on uploading image on macos (AppFlowy-IO#5272)
  fix: launch review improvements (AppFlowy-IO#5263)
  chore: drop old user awarenss when open workspace (AppFlowy-IO#5271)
  fix: korean IME issue on Windows (AppFlowy-IO#5267)
  fix: the cursor will jump up when creating a new document on desktop. (AppFlowy-IO#5269)
  ...
@zoli zoli mentioned this pull request Jun 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xazin Xazin Xazin left review comments

Assignees
No one assigned
Labels
kanban board features related to the board-view database new feature New feature or request v0.5.8
Projects
None yet
Milestone
No milestone
2 participants
@richardshiue @Xazin