Shortcut exit link 2393 #124
Conversation
Support the mobile platforms (iOS and Android) and make the editor more extensible.
|
|
| onKey: (key) { | ||
| if (key is! RawKeyDownEvent) return; | ||
| if (key.logicalKey == LogicalKeyboardKey.escape) { | ||
| widget.onDismiss(); | ||
| } | ||
| }, |
There was a problem hiding this comment.
Sort child last (below this)
| @@ -21,6 +21,7 @@ void main() async { | |||
| onSubmitted: (text) { | |||
| submittedText = text; | |||
| }, | |||
| onDismiss: () {} | |||
There was a problem hiding this comment.
Can you add a test case for this?
| onDismiss: () { | ||
| _dismissOverlay(); | ||
| }, |
There was a problem hiding this comment.
| onDismiss: () { | |
| _dismissOverlay(); | |
| }, | |
| onDismiss: _dismissOverlay, |
| return RawKeyboardListener( | ||
| focusNode: FocusNode(), | ||
| onKey: (key) { | ||
| if (key is! RawKeyDownEvent) return; |
There was a problem hiding this comment.
| if (key is! RawKeyDownEvent) return; | |
| if (key is! RawKeyDownEvent) { | |
| return; | |
| } |
IIRC, Effective Dart says to use curly braces.
| controller: _textEditingController, | ||
| onSubmitted: widget.onSubmitted, | ||
| decoration: InputDecoration( | ||
| hintText: 'URL', |
There was a problem hiding this comment.
Please use a translatable string for this hint text.
See locale_keys.g.dart... you can add a key, value pair of your choice to en.json and run a task (control+shift+p, then type task: generate...) to generate the LocaleKeys, then you can use it here like so:
hintText: LocaleKeys.url_label.tr();There was a problem hiding this comment.
Currently, within appflowy-editor, I don't understand how the language management works, and there is a lack of documentation. It's okay to add it to the main project, but I don't understand how to pass it to appflowy-editor.
Can we do it in a separate pull request so that we can manage all the labels?
There was a problem hiding this comment.
Let's add internationalization before this pull request lands. You can DM me on discord (a-wallen#0603) if you need help. I'm happy to hop on a call to show you how this is done.
cc @LucasXu0, we might want to add better documentation for internationalization per this comment.
There was a problem hiding this comment.
Sure. The translation for the editor is different from the main project. Here's the guide link: https://github.com/AppFlowy-IO/appflowy-editor/blob/main/documentation/translation.md
There was a problem hiding this comment.
Thanks @LucasXu0 , done!
| ), | ||
| border: const OutlineInputBorder( | ||
| borderRadius: BorderRadius.all(Radius.circular(12.0)), | ||
| borderSide: BorderSide(color: Color(0xFFBDBDBD)), |
There was a problem hiding this comment.
Please reference a grey color from the app theme. See color_scheme.dart. The shaders from color_scheme should be approximate.
|
Hey, @vincenzoursano. Thanks for contributing. Would you mind changing the merge branch to the |
vincenzoursano
force-pushed
the
shortcut_exit_link_2393
branch
from
ffba9da
to
18339b8
Compare
|
Hi @LucasXu0, I changed the merge branch. Do we need to do anything else? |
|
Status? |
|
LGTM @annieappflowy, but cc @LucasXu0 because there are no CI workflows running tests. |
vincenzoursano
force-pushed
the
shortcut_exit_link_2393
branch
from
6daa812
to
ce9ac43
Compare
|
Sorry, I fixed the commit message that was blocking the CI. |
LucasXu0
force-pushed
the
shortcut_exit_link_2393
branch
from
e27b829
to
ce9ac43
Compare
Codecov Report
@@ Coverage Diff @@
## main #124 +/- ##
==========================================
+ Coverage 62.61% 62.64% +0.03%
==========================================
Files 246 246
Lines 10857 10869 +12
==========================================
+ Hits 6798 6809 +11
- Misses 4059 4060 +1
|
AppFlowy-IO/AppFlowy#2393
@annieappflowy