fix: selection menu positioning on right half of editor #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #600 +/- ##
=======================================
Coverage 78.87% 78.87%
=======================================
Files 289 289
Lines 12526 12526
=======================================
Hits 9880 9880
Misses 2646 2646 ☔ View full report in Codecov by Sentry. |
Agreed. We should redesign the slash menu on desktop platform. |
q200892907
added a commit
to q200892907/appflowy-editor
that referenced
this pull request
Nov 23, 2023
* main: fix: floating toolbar position error (AppFlowy-IO#598) fix: selection menu positioning on right half of editor (AppFlowy-IO#600) feat: show magnifier when dragging the handlers (AppFlowy-IO#601) fix: editor cannot scroll when editable is false (AppFlowy-IO#599)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of AppFlowy-IO/AppFlowy#3414.
The problem was presupposing that the editor width equal to the application width. So when there was something like a sidebar in AppFlowy the calculations were going wrong.
There will be still issues with the selection menu because the width is too long. It should get shorter and other items should get access through scroll.
Personally, I prefer a vertical menu rather than a horizontal one.