Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: header/footer focus issue #607

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

q200892907
Copy link
Contributor

2023-11-28.14.31.07.mov

#542

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (af9f97e) 78.77% compared to head (cfb4b80) 78.61%.
Report is 6 commits behind head on main.

Files Patch % Lines
...t/base_component/widget/ignore_parent_gesture.dart 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #607      +/-   ##
==========================================
- Coverage   78.77%   78.61%   -0.17%     
==========================================
  Files         290      291       +1     
  Lines       12552    12584      +32     
==========================================
+ Hits         9888     9893       +5     
- Misses       2664     2691      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@q200892907
Copy link
Contributor Author

q200892907 commented Dec 1, 2023

@LucasXu0 Solve the problem of some shortcut operation keys failing when adding TextField at the Header or Footer, including select all cut undo

@LucasXu0 LucasXu0 changed the title fix:header/footer focus issue fix: header/footer focus issue Dec 7, 2023
@LucasXu0 LucasXu0 merged commit be92cfa into AppFlowy-IO:main Dec 8, 2023
8 of 11 checks passed
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Dec 8, 2023
* main:
  fix: header/footer focus issue (AppFlowy-IO#607)
@q200892907 q200892907 deleted the fix-header_footer_focus_issue branch December 8, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants