Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support customizing the mobile magnifiter #625

Merged
merged 5 commits into from
Dec 19, 2023

Conversation

LucasXu0
Copy link
Collaborator

using the magnifierSize to customize the mobile magnifier size.

magnifiter.mp4

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Comparison is base (e6b1336) 78.67% compared to head (033b205) 78.34%.

Files Patch % Lines
...nt/service/selection/mobile_selection_service.dart 8.82% 31 Missing ⚠️
...component/service/selection/mobile_magnifiter.dart 0.00% 8 Missing ⚠️
...ditor_component/service/scroll_service_widget.dart 0.00% 4 Missing ⚠️
...bile_floating_toolbar/mobile_floating_toolbar.dart 0.00% 3 Missing ⚠️
...or_component/service/selection_service_widget.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #625      +/-   ##
==========================================
- Coverage   78.67%   78.34%   -0.33%     
==========================================
  Files         290      290              
  Lines       12621    12683      +62     
==========================================
+ Hits         9930     9937       +7     
- Misses       2691     2746      +55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit 82f3baf into AppFlowy-IO:main Dec 19, 2023
9 of 11 checks passed
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Dec 25, 2023
* main:
  feat: support keep editor focus on mobile (AppFlowy-IO#628)
  fix: indent/outdent doesn't work in not collapsed selection (AppFlowy-IO#626)
  feat: support customizing the mobile magnifiter (AppFlowy-IO#625)

# Conflicts:
#	lib/src/editor/editor_component/service/keyboard_service_widget.dart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant