Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: indent/outdent doesn't work in not collapsed selection #626

Merged
merged 1 commit into from
Dec 21, 2023
Merged

fix: indent/outdent doesn't work in not collapsed selection #626

merged 1 commit into from
Dec 21, 2023

Conversation

LucasXu0
Copy link
Collaborator

No description provided.

@codecov Codecov
Copy link

codecov bot commented Dec 21, 2023 •
edited
Loading

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (82f3baf) 78.34% compared to head (b1e5587) 78.16%.

Files Patch % Lines
...lock_component/base_component/outdent_command.dart 11.11% 8 Missing ⚠️
...block_component/base_component/indent_command.dart 12.50% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #626      +/-   ##
==========================================
- Coverage   78.34%   78.16%   -0.18%     
==========================================
  Files         290      290              
  Lines       12683    12698      +15     
==========================================
- Hits         9937     9926      -11     
- Misses       2746     2772      +26

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit 739cd59 into AppFlowy-IO:main Dec 21, 2023
9 of 11 checks passed
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Dec 25, 2023
@q200892907
Merge branch 'main' into feat-zhiya
0599d4f 
* main:
  feat: support keep editor focus on mobile (AppFlowy-IO#628)
  fix: indent/outdent doesn't work in not collapsed selection (AppFlowy-IO#626)
  feat: support customizing the mobile magnifiter (AppFlowy-IO#625)

# Conflicts:
#	lib/src/editor/editor_component/service/keyboard_service_widget.dart
@LucasXu0 LucasXu0 mentioned this pull request Jan 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LucasXu0