Localize more items #680

jpenna · 2024-01-19T20:18:59Z

This is related to the PR AppFlowy-IO/AppFlowy#4426

It should be merged before the one in the app is merged.

I'm also doing the PT-BR translation in this PR to verify all texts are correctly replaced.

CLAassistant · 2024-01-19T20:19:05Z

All committers have signed the CLA.

LucasXu0 · 2024-01-20T15:39:29Z

Hi, @jpenna. I converted it to a draft PR. Please mark it as ready for review if it's ready.

jpenna · 2024-01-20T17:56:09Z

assets/images/toolbar/text_direction_ltr.svg

I renamed the icons for text_direction_right and left to text_direction_ltr and rtl, respectively. The meaning of the image is clearer this way and they were actually used with the opposite command.

jpenna · 2024-01-20T17:57:21Z

lib/l10n/intl_en.arb

@@ -1,79 +1,42 @@
 {
  "@@locale": "en",
  "bold": "Bold",
-  "@bold": {},


I removed these metadatas because they were useless bloat in these situations.

jpenna · 2024-01-20T17:58:11Z

lib/l10n/intl_en.arb

+  "cmdDontAddNewLineInTableCell": "Don't add new line in table cell",
+  "cmdMoveToLeftCellIfItsAtStartOfCurrentCell": "Move to left cell if its at start of current cell",
+  "cmdMoveToRightCellIfItsAtTheEndOfCurrentCell": "Move to right cell if its at the end of current cell",
+  "cmdMoveToUpCellAtSameOffset": "Move to up cell at same offset",
+  "cmdMoveToDownCellAtSameOffset": "Move to down cell at same offset",
+  "cmdNavigateAroundTheCellsAtSameOffset": "Navigate around the cells at same offset",
+  "cmdNavigateAroundTheCellsAtSameOffsetInReverse": "Navigate around the cells at same offset in reverse",
+  "cmdStopAtTheBeginningOfTheCell": "Stop at the beginning of the cell"


These will be useful for AppFlowy-IO/AppFlowy#4426

jpenna · 2024-01-20T17:59:05Z

lib/src/editor/block_component/table_block_component/table_action_menu.dart

+                  ? AppFlowyEditorL10n.current.colAddBefore
+                  : AppFlowyEditorL10n.current.rowAddBefore,
              dir == TableDirection.col
-                  ? Icons.last_page
-                  : Icons.vertical_align_bottom, () {
-            TableActions.add(node, position + 1, editorState, dir);
+                  ? Icons.first_page
+                  : Icons.vertical_align_top, () {
+            TableActions.add(node, position, editorState, dir);
            dismissOverlay();
          }),
          _menuItem(
              context,
              dir == TableDirection.col
-                  ? AppFlowyEditorL10n.current.colAddBefore
-                  : AppFlowyEditorL10n.current.rowAddBefore,
+                  ? AppFlowyEditorL10n.current.colAddAfter
+                  : AppFlowyEditorL10n.current.rowAddAfter,
              dir == TableDirection.col
-                  ? Icons.first_page
-                  : Icons.vertical_align_top, () {
-            TableActions.add(node, position, editorState, dir);
+                  ? Icons.last_page
+                  : Icons.vertical_align_bottom, () {
+            TableActions.add(node, position + 1, editorState, dir);


I changed the order of these two, so "add before" comes before "add after", which makes more sense.

jpenna · 2024-01-20T18:02:38Z

lib/src/editor/block_component/table_block_component/table_block_component.dart

@@ -251,7 +251,7 @@ class _TableBlockComponentWidgetState extends State<TableBlockComponentWidget>
 }

 SelectionMenuItem tableMenuItem = SelectionMenuItem(
-  name: AppFlowyEditorL10n.current.table,
+  getName: () => AppFlowyEditorL10n.current.table,


A better way to achieve this same thing would be to rebuild everything if Intil changes, but then it would require a long refactor of many classes to use Localizations.of(context) or add some listener to rebuild everything. Probably something to be thought about later?

jpenna · 2024-01-20T18:10:09Z

I'll send another PR with the translations of commands. It will be quite large, so we can merge this one first.

LucasXu0 · 2024-01-24T14:51:23Z

@jpenna One test failed. Please check it.

codecov · 2024-01-25T01:38:43Z

Codecov Report

Attention: 71 lines in your changes are missing coverage. Please review.

Comparison is base (3cd5602) 76.46% compared to head (0a3a92e) 76.39%.

Files	Patch %	Lines
lib/src/l10n/l10n.dart	15.38%	33 Missing ⚠️
...omponent/table_block_component/table_commands.dart	0.00%	14 Missing ⚠️
...itor/toolbar/desktop/items/utils/tooltip_util.dart	47.82%	12 Missing ⚠️
...onent/table_block_component/table_action_menu.dart	0.00%	8 Missing ⚠️
...nent/service/shortcuts/command_shortcut_event.dart	0.00%	1 Missing ⚠️
...c/editor/selection_menu/selection_menu_widget.dart	50.00%	1 Missing ⚠️
...toolbar/desktop/items/alignment_toolbar_items.dart	0.00%	1 Missing ⚠️
...ar/desktop/items/text_direction_toolbar_items.dart	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #680      +/-   ##
==========================================
- Coverage   76.46%   76.39%   -0.08%     
==========================================
  Files         295      295              
  Lines       13094    13309     +215     
==========================================
+ Hits        10012    10167     +155     
- Misses       3082     3142      +60

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* main: fix: pasting keeps current node type (AppFlowy-IO#689) chore: localize more items (AppFlowy-IO#680) fix: windows chinese ime issue (AppFlowy-IO#682) fix: upgrade markdown to 7.2.1 (AppFlowy-IO#686)

LucasXu0 marked this pull request as draft January 20, 2024 15:38

jpenna commented Jan 20, 2024

View reviewed changes

jpenna marked this pull request as ready for review January 20, 2024 18:05

jpenna marked this pull request as draft January 20, 2024 18:07

jpenna marked this pull request as ready for review January 20, 2024 18:09

This was referenced Jan 24, 2024

Translate commands #687

Merged

[Bug] non translateable labels AppFlowy-IO/AppFlowy#4276

Closed

Fix: Enable more text to be translated AppFlowy-IO/AppFlowy#4426

Merged

jpenna added 7 commits January 24, 2024 18:49

fix: localize tooltips from toolbar items

9c6c901

fix: Localize shortcut descriptions

0f8002d

refactor: reorder able menu entries

82012db

fix: update translation if locale changes

1bec9a2

feat: translate all pt-BR

7b42ab6

docs: explain how to change locales

1bdcd7c

ci: fix failing unit test

0a3a92e

jpenna force-pushed the a4276-translations branch from f962696 to 0a3a92e Compare January 24, 2024 21:50

LucasXu0 approved these changes Jan 25, 2024

View reviewed changes

LucasXu0 merged commit 7fe3ff7 into AppFlowy-IO:main Jan 25, 2024
8 of 11 checks passed

jpenna deleted the a4276-translations branch January 25, 2024 16:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Localize more items #680

Localize more items #680

jpenna commented Jan 19, 2024 •

edited

Loading

CLAassistant commented Jan 19, 2024 •

edited

Loading

LucasXu0 commented Jan 20, 2024

jpenna Jan 20, 2024

jpenna Jan 20, 2024

jpenna Jan 20, 2024

jpenna Jan 20, 2024

jpenna Jan 20, 2024

jpenna commented Jan 20, 2024

LucasXu0 commented Jan 24, 2024

codecov bot commented Jan 25, 2024 •

edited

Loading

Localize more items #680

Localize more items #680

Conversation

jpenna commented Jan 19, 2024 • edited Loading

CLAassistant commented Jan 19, 2024 • edited Loading

LucasXu0 commented Jan 20, 2024

jpenna Jan 20, 2024

Choose a reason for hiding this comment

jpenna Jan 20, 2024

Choose a reason for hiding this comment

jpenna Jan 20, 2024

Choose a reason for hiding this comment

jpenna Jan 20, 2024

Choose a reason for hiding this comment

jpenna Jan 20, 2024

Choose a reason for hiding this comment

jpenna commented Jan 20, 2024

LucasXu0 commented Jan 24, 2024

codecov bot commented Jan 25, 2024 • edited Loading

Codecov Report

jpenna commented Jan 19, 2024 •

edited

Loading

CLAassistant commented Jan 19, 2024 •

edited

Loading

codecov bot commented Jan 25, 2024 •

edited

Loading