Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert ime changes #701

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Feb 1, 2024

No description provided.

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (e80edfc) 75.50% compared to head (a758081) 75.46%.

Files Patch % Lines
...rvice/ime/delta_input_on_non_text_update_impl.dart 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #701      +/-   ##
==========================================
- Coverage   75.50%   75.46%   -0.05%     
==========================================
  Files         296      296              
  Lines       13630    13632       +2     
==========================================
- Hits        10291    10287       -4     
- Misses       3339     3345       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit 8a5ca2a into AppFlowy-IO:main Feb 1, 2024
9 of 11 checks passed
@adsonpleal
Copy link

Just a FYK, Platform.isMacOS was breaking the 2.3.1 version for the web.

q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Feb 19, 2024
* main:
  chore: upgrade flutter version to 3.19.0 (AppFlowy-IO#719)
  fix: the positioning of the slash command menu in the web version (AppFlowy-IO#709)
  fix: unable to export image block in markdown format (AppFlowy-IO#713)
  feat: debounce on word count service (AppFlowy-IO#711)
  feat: on demand word count without listening (AppFlowy-IO#710)
  feat: support selection counters (AppFlowy-IO#706)
  feat: word counter service (AppFlowy-IO#705)
  chore: bump version 2.3.2
  chore: update Chinese i18n (AppFlowy-IO#698)
  fix: fix checkbox not work as expected in html module. (AppFlowy-IO#700)
  chore: revert ime changes (AppFlowy-IO#701)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants