feat: word counter service #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #705 +/- ##
==========================================
+ Coverage 75.47% 75.54% +0.07%
==========================================
Files 296 297 +1
Lines 13638 13678 +40
==========================================
+ Hits 10293 10333 +40
Misses 3345 3345 ☔ View full report in Codecov by Sentry. |
LucasXu0
reviewed
Feb 7, 2024
LucasXu0
reviewed
Feb 7, 2024
q200892907
added a commit
to q200892907/appflowy-editor
that referenced
this pull request
Feb 19, 2024
* main: chore: upgrade flutter version to 3.19.0 (AppFlowy-IO#719) fix: the positioning of the slash command menu in the web version (AppFlowy-IO#709) fix: unable to export image block in markdown format (AppFlowy-IO#713) feat: debounce on word count service (AppFlowy-IO#711) feat: on demand word count without listening (AppFlowy-IO#710) feat: support selection counters (AppFlowy-IO#706) feat: word counter service (AppFlowy-IO#705) chore: bump version 2.3.2 chore: update Chinese i18n (AppFlowy-IO#698) fix: fix checkbox not work as expected in html module. (AppFlowy-IO#700) chore: revert ime changes (AppFlowy-IO#701)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first idea was to setup a listener to the Transaction stream of the EditorState, and then update the counters only with the changeset, but this seems not quite possible with how operations currently work.
Currently, an UpdateOperation contains inserts in the delta, and whilst we do have the old attributes to compare against, it seems that it can happen that the new attributes delta can be a subset of the old one, causing it to be near impossible to rely on the difference in characters and words as the comparison of the two might not be representative of the actual changes to the document.
We can improve and build on this (eg. add Selection word/char count to the service) in the future.