Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files checked in for AppDirAssistant. #17

Merged
merged 1 commit into from
Mar 20, 2015
Merged

Files checked in for AppDirAssistant. #17

merged 1 commit into from
Mar 20, 2015

Conversation

Manouchehri
Copy link
Contributor

Taken from the x86-64 binary.

@RazZziel
Copy link

Shouldn't we be .gitignoring all .pyc files?

@Manouchehri
Copy link
Contributor Author

Wouldn't be a bad idea. I don't have access to my computer right now, but I thought those .pyc were actually included in the AppImage already when I extracted it. (I ran a diff on the extracted x86-64 vs x86 folders and I believe they had the same .pyc files.)

Also, at the moment nothing has been added to the build scripts for AppDirAssistant and it won't run on 32-bit since I only have the 64-bit binary in there.

All I'm checking in is the extracted files; I would be happy if somebody else was willing to go to the trouble of cleaning and setting up the build config properly though.

@probonopd
Copy link
Member

True, the pyc files were an earlier mistake of mine; we should replace them by the py equivalents

@Manouchehri
Copy link
Contributor Author

@probonopd Could you merge in the copy of AppDirAssistant that you have?

For an actual AppImage, doesn't pyc make more sense? The file isn't going to be modified at runtime anyway.

probonopd added a commit that referenced this pull request Mar 20, 2015
Files checked in for AppDirAssistant.
@probonopd probonopd merged commit ab504ef into AppImage:master Mar 20, 2015
@RazZziel
Copy link

They're cache files, I don't know if they'll cause trouble with different versions of the Python interpreter, which right now lives on the host machine and not in the AppImage so we can't control it.

Actually, for AppImage deployment, I think it'd be better to compile the python application and avoid depending on anythin in the host machine. I'm (extreeeemely slowly) trying out http://nuitka.net/, which looks promising for that purpose.

Anyway, for the repository itself, pyc files shoul definitely be left out :)
Interesting read: https://coderwall.com/p/wrxwog/why-not-to-commit-pyc-files-into-git-and-how-to-fix-if-you-already-did

@probonopd
Copy link
Member

http://nuitka.net/ looks interesting, could we use it to compile all our stuff?

@RazZziel
Copy link

Yup, all of it :) seems to be able to compile any Python app with any dependencies
I just tried it on AppImageAssistant 0.9, seems to have problems mixing python3 and python2; but I'll keep trying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants