Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uncomment bitbucket-related code #3258

Merged
merged 24 commits into from
Sep 13, 2023
Merged

uncomment bitbucket-related code #3258

merged 24 commits into from
Sep 13, 2023

Conversation

kfjahnke
Copy link
Contributor

Having tested as best as I could that the bitbucket-related code works as intended, I propose this pull request to re-activate it.

kfjahnke and others added 24 commits August 3, 2023 19:18
The latest upload has an AppImage of lux 1.1.8 built on ubuntu 20.04 instead of 18.04. It also has a new version of metadata.xml
this version should provide a better default screenshot, avoiding the
INVALID MESSAGE WITH QUOTES output. With the recent changes in worker.sh,
re-rendering the catalog entry should also produce a 'download' button.
@probonopd
Copy link
Member

Thanks @kfjahnke, let's see how it goes.

@probonopd
Copy link
Member

probonopd commented Sep 13, 2023

Running into issues again:
https://github.com/AppImage/appimage.github.io/actions/runs/6176528675/job/16765645722#step:5:1476

++ grep '^https://bitbucket.org///downloads/.*AppImage$' data/ubpm
+ BB_LINK=
worker.sh exited with a non-zero code: 1

probonopd added a commit that referenced this pull request Sep 13, 2023
probonopd added a commit that referenced this pull request Sep 13, 2023
@kfjahnke
Copy link
Contributor Author

So the last output of the test before the error is
BB_LINK=
it is empty, which is correct for ubpm. So the test
if [ x"$BB_LINK" != x"" ]
should fail, processing should continue after the 'fi', but it looks like the test isn't reached at all.

I can't see how this should should produce the exit with code 1, but it's hard to see because the exit code '1' is used in several places. The only thing I do differently is that I don't pipe the grep's output into sed to replace https with http, because the RE I grep for does not catch http without the trailing 's'. Be that as it may, I'll follow the template of OBS_LINK to the letter, change the grep and add the pipe to sed, then we can try if that works. I'll open a new PR.

@kfjahnke
Copy link
Contributor Author

One more thing before I push the PR: I had a look at the AppImage you used for testing (ubpm) and noticed that the source is using the vcs-browser tag in their metadata.xml. Is it possible that your test chokes on that? They might have updated their metadat.xml to the new spec, making your older version of appstream-cli which does not recognize that tag fail on the input. I still think there is nothing wrong with the bitbucket-related code, but I'll send the PR anyway.

kfjahnke pushed a commit to kfjahnke/appimage.github.io that referenced this pull request Sep 14, 2023
…B_LINK

to follow the same pattern that is used for OBS_LINK, as announced in AppImage#3258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants