-
-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uncomment bitbucket-related code #3258
Conversation
The latest upload has an AppImage of lux 1.1.8 built on ubuntu 20.04 instead of 18.04. It also has a new version of metadata.xml
…s with download section
entering the .md file
this version should provide a better default screenshot, avoiding the INVALID MESSAGE WITH QUOTES output. With the recent changes in worker.sh, re-rendering the catalog entry should also produce a 'download' button.
…tion if it offers AppImages
Thanks @kfjahnke, let's see how it goes. |
Running into issues again:
|
This reverts commit 2c1fca4.
This reverts commit 2c1fca4.
So the last output of the test before the error is I can't see how this should should produce the exit with code 1, but it's hard to see because the exit code '1' is used in several places. The only thing I do differently is that I don't pipe the grep's output into sed to replace https with http, because the RE I grep for does not catch http without the trailing 's'. Be that as it may, I'll follow the template of OBS_LINK to the letter, change the grep and add the pipe to sed, then we can try if that works. I'll open a new PR. |
One more thing before I push the PR: I had a look at the AppImage you used for testing (ubpm) and noticed that the source is using the vcs-browser tag in their metadata.xml. Is it possible that your test chokes on that? They might have updated their metadat.xml to the new spec, making your older version of appstream-cli which does not recognize that tag fail on the input. I still think there is nothing wrong with the bitbucket-related code, but I'll send the PR anyway. |
…B_LINK to follow the same pattern that is used for OBS_LINK, as announced in AppImage#3258
Having tested as best as I could that the bitbucket-related code works as intended, I propose this pull request to re-activate it.