Make the descriptions on the intro pages scrollable

[EasyVector]

Dear developer:

Hello! I am the creator of issue #963, and I have fixed the blocked descriptions to make it more responsive. I would appreciate it if you could kindly revise my code and leave me some advice. Thank you so much for your precious time!

Here are the screenshots after my changes:

Thanks again! Blessings on your day! :)

[franklinbill]

I met this mistake again. Great! I agree with your fix 👍 @yuhuitech

[cortinico]

Thanks for your PR 🙏

The layout-land file should also be adapted.

[cortinico]

The scrollview is not needed. It should be enought with:

android:scrollbars = "vertical"

Plus

textView.setMovementMethod(new ScrollingMovementMethod());

[EasyVector]

OK, I will work on this right now. :)
Thank you so much!

[EasyVector]

Hi! Those two methods seem to have the same effect as far as I am concerned. And I also guess it would be easier to maintain the project if we let the XML do all the rendering work. Editing Java files would also work, but maybe it is harder for other developers to associate it with the XML file. This is my opinion. I would appreciate it if you could give me some advice on this. Thank you so much! :)

[EasyVector]

If it is OK with you I would like to do the adaptation work of the landscape mode. :)

[cortinico]

Let's go with the XML only approach 👍

[cortinico]

Please note this:

The scrollview is not needed.

You can remove the ScrollView entirely 👍

[EasyVector]

Hi! Sorry for the wait. I guess I have solved the problem when the landscape mode is used. Here are some screenshots after modifications when using the largest display size:

and the smallest display size:

I am looking forward to your review. Thanks again for your kindness and your precious time!! :)

[EasyVector]

You can remove the ScrollView entirely

If I remove the ScrollView, should I use the java code you recommended earlier?

[cortinico]

Please do your own researches/trial and let me know what's the outcome.
The solution with the least amount of changes is generally preferred.

Like if we can solve it by just adding an XML attribute, that would be the preferred approach.

[EasyVector]

OK, I could comprehend the meaning you are trying to deliver to me now. Therefore I would like to make a comparison of those two methods and I would like to inform you of this once it is ready. And I will also minimize the changes I could apply to those files. :)
Thanks again!

[EasyVector]

Hello! Sorry for the wait. After my research on this project and this problem, I would like to recommend you modify XML files only. Here is the reason.

I did some investigations on this project and I found that maybe it is the "AppIntroBaseFragment.kt" file that controls the creation of the views on the Intro pages, which is this function onCreateView, more specifically. I applied some changes to it, just like this:

    override fun onCreateView(
        inflater: LayoutInflater,
        container: ViewGroup?,
        savedInstanceState: Bundle?
    ): View? {
        val view = inflater.inflate(layoutId, container, false)
        val titleText = view.findViewById<TextView>(R.id.title)
        val descriptionText = view.findViewById<TextView>(R.id.description)
        val slideImage = view.findViewById<ImageView>(R.id.image)
        val mainLayout = view.findViewById<ConstraintLayout>(R.id.main)

        // Make the description texts scrollable
        descriptionText.setMovementMethod(ScrollingMovementMethod())

        titleText.text = title
        descriptionText.text = description
        if (titleColor != 0) {
            titleText.setTextColor(titleColor)
        }
        if (descColor != 0) {
            descriptionText.setTextColor(descColor)
        }
        titleTypeface?.applyTo(titleText)
        descTypeface?.applyTo(descriptionText)

        slideImage.setImageResource(drawable)
        if (bgDrawable != 0) {
            mainLayout?.setBackgroundResource(bgDrawable)
        } else {
            mainLayout?.setBackgroundColor(defaultBackgroundColor)
        }

        return view
    }

In the meantime, I also revoked all the changes I applied to those two XML files. Then I started my test.

Here are some normal screenshots after my test, and in such circumstances, those text views could be seen fully:

And it also could handle the situation where an extremly longer sentence is in the text view.

However, this screenshot is not that charming when it comes to the land mode, mainly for the title. As you could see, a part of the title is blocked by its border. But the description is scrollable.

According to my comparison, I found some layout issues in the land mode, which are caused by the XML file. So I guess the land mode XML file needs a repair. From the screenshots I have shown you before, I reckon that I have tackled this problem without changing any kt or java code, just some modifications on the XML files. That is, after my modifications, the long title on the land mode is not blocked.

So my final conclusion is that perhaps we don't need to change any kt or java files but only XML files to reach this goal.

That is my opinion. I am very humble and sincere so I would be so glad if you could leave me some advice on this. And I would like to make contributions to this project with all of my best efforts. :)

Thanks again!

[cortinico]

Thanks for your clarification and for taking the time to look into this,

So my final conclusion is that perhaps we don't need to change any kt or java files but only XML files to reach this goal.

Are you suggesting we go with the ScrollView approach right?

[EasyVector]

Yes, we should go with the ScrollView approach. :)

[cortinico]

Yes, we should go with the ScrollView approach. :)

I would like to take a view at my implementation here: 91909ec

It doesn't use the ScrollView yet achieves the same solution.
I believe the only problem left is the Title in Land mode, but I think we should tune the text autosizing for that specific scenario.

[EasyVector]

Yes, I also believe tuning is necessary and I would like to try your code.

And I also would like to add that since those introduction pages are static and they don't need changes during running time, I believe it would be better to declare UI layouts in XML files considering performance, speed as such.

[cortinico]

Yes, I also believe tuning is necessary and I would like to try your code.

What's the status of this PR?

[EasyVector]

Yes, I also believe tuning is necessary and I would like to try your code.

What's the status of this PR?

Hello! I am quite busy recently, and I have tested your code already, and I think they are good to go. Making those text scrollable is a wonderful choice.

[cortinico]

Thanks for the feedback. I believe we might want to include this change into #978