Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make description scrollable #993

Merged
merged 1 commit into from
Jan 8, 2022
Merged

Make description scrollable #993

merged 1 commit into from
Jan 8, 2022

Conversation

cortinico
Copy link
Member

@cortinico cortinico commented Jan 8, 2022 •
edited

Closes #964
Fixes #963

Using ScrollingMovementMethod to make the two TextView scrollable. Here is a sample on both Land and Port model with very long texts.

Port Land
https://user-images.githubusercontent.com/3001957/148656344-d94ca4f2-7e9a-4adb-996a-ed0a5e1b4663.mp4 https://user-images.githubusercontent.com/3001957/148656395-2ca98f71-d0b7-41ff-aa72-e241f1b741af.mp4

@cortinico cortinico added the enhancement Issue/PR related to a new feature for the library label Jan 8, 2022
@paolorotolo paolorotolo merged commit 3a301e4 into main Jan 8, 2022
@paolorotolo paolorotolo deleted the nc/scrollable_description branch January 8, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paolorotolo paolorotolo paolorotolo approved these changes

Assignees
No one assigned
Labels
enhancement Issue/PR related to a new feature for the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Descriptions are blocked when using the largest font and display size
2 participants
@cortinico @paolorotolo