-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/callback_table_objc #6
Conversation
|
||
cell.textLabel.text = self.callbacks[indexPath.row]; | ||
cell.textLabel.numberOfLines = 2; | ||
cell.textLabel.adjustsFontSizeToFitWidth = YES; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two lines can be done in the storyboard, same goes for the Swift PR.
- (void)didLoadAd:(MAAd *)ad {} | ||
- (void)didLoadAd:(MAAd *)ad | ||
{ | ||
[super logCallback: __PRETTY_FUNCTION__]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super
should only be called when overriding a function (can't think of any other use cases). These sub-classes implicitly inherit logCallback
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^same goes for the rest of the super logCallback
Changes made |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg2m
https://app.asana.com/0/573104092700345/1139118931272208