Don't crash if min and max are not set. #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New OCD run after the extension to check all parameters not only min and max: https://ocd.appscale.com:8080/job/Daily%20Build/307/ |
In particular if string is not Integer, we need to capture error right away.
|
latest OCD run https://ocd.appscale.com:8080/job/Daily%20Build/319/ |
| msg = "Removing parameter '" + key + "' with unknown value '" +\ | ||
| val.to_s + "'." | ||
| rescue | ||
| msg = "Removing parameter '" + key + "' has unknown value." |
|
tested with the configuration that created problems: infrastructure : 'euca' |
This is to inform that the log to dashboard needs to be enabled.
We need to add the test to enable the sending and testing it.
|
Latest ocd run: https://ocd.appscale.com:8080/job/Daily%20Build/331/ |
…x-scaling-integers
|
latest OCD run https://ocd.appscale.com:8080/job/Daily%20Build/343/ |
cdonati
added a commit
that referenced
this pull request
Jul 31, 2015
Don't crash if min and max are not set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.