Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run job and job run status #8

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Run job and job run status #8

merged 1 commit into from
Jan 13, 2020

Conversation

agaffney
Copy link
Contributor

@agaffney agaffney commented Jan 10, 2020 •
edited
Loading

  • support multiple steps in a test
  • support preserving keys from response in one step to use in another
  • support for specifying HTTP status code in JsonError()
  • return 404 in cases where we are given a specific job ID and get an error

wolf31o2
wolf31o2 previously approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@wolf31o2 wolf31o2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo, but it's in a comment, so feel free to fix it separately.

src/helpers/helpers.go Outdated Show resolved Hide resolved
wolf31o2
wolf31o2 previously approved these changes Jan 10, 2020
View reviewed changes
tmad
tmad reviewed Jan 13, 2020
View reviewed changes
src/api/runs.go Outdated Show resolved Hide resolved
tmad
tmad reviewed Jan 13, 2020
View reviewed changes
src/api/runs.go Outdated Show resolved Hide resolved
@agaffney
Run job and job run status
feec643 
* support multiple steps in a test
* support preserving keys from response in one step to use in another
* support for specifying HTTP status code in JsonError()
* return 404 in cases where we are given a specific job ID and get an error
@agaffney agaffney merged commit 4153df6 into master Jan 13, 2020
@agaffney agaffney deleted the PD-5211-run-job branch January 13, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmad tmad tmad approved these changes

@wolf31o2 wolf31o2 wolf31o2 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agaffney @wolf31o2 @tmad