Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run job and job run status #8

Merged
merged 1 commit into from Jan 13, 2020
Merged

Run job and job run status #8

merged 1 commit into from Jan 13, 2020

Conversation

@agaffney
Copy link
Contributor

agaffney commented Jan 10, 2020

  • support multiple steps in a test
  • support preserving keys from response in one step to use in another
  • support for specifying HTTP status code in JsonError()
  • return 404 in cases where we are given a specific job ID and get an error
Copy link
Contributor

wolf31o2 left a comment

There's a typo, but it's in a comment, so feel free to fix it separately.

src/helpers/helpers.go Outdated Show resolved Hide resolved
@agaffney agaffney force-pushed the PD-5211-run-job branch from d7858af to 9e06eb8 Jan 10, 2020
src/api/runs.go Outdated Show resolved Hide resolved
src/api/runs.go Outdated Show resolved Hide resolved
* support multiple steps in a test
* support preserving keys from response in one step to use in another
* support for specifying HTTP status code in JsonError()
* return 404 in cases where we are given a specific job ID and get an error
@agaffney agaffney force-pushed the PD-5211-run-job branch from 9e06eb8 to feec643 Jan 13, 2020
@tmad
tmad approved these changes Jan 13, 2020
@agaffney agaffney merged commit 4153df6 into master Jan 13, 2020
2 checks passed
2 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
@agaffney agaffney deleted the PD-5211-run-job branch Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.