Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disk activity indicators for drives in Slot 5 #1134

Closed
skiphipdata opened this issue Oct 5, 2022 · 22 comments
Closed

Disk activity indicators for drives in Slot 5 #1134

skiphipdata opened this issue Oct 5, 2022 · 22 comments

Comments

@skiphipdata
Copy link

It would be nice to have a separate set of disk activity "LEDs" for the drives in Slot 5.

@tomcw
Copy link
Contributor

tomcw commented Oct 16, 2022

This feels like a useful think to add, so let me share some work in progress...

I added extra "Slot 5" Disk-II LEDs & track/sector status, below the "Slot 6" Disk-II status:
(Only visible in 2x Windowed mode)
image

But I felt there was too much track/sector debug "noise" for a regular user, so I made it only visible via this extra config checkbox:
NB. the "Slot 6" track/sector status is always visible in 2x Windowed mode)
Config-Disk

@burniouf
Copy link

wouldn't it be possible to display also exact Quarter track position for all Disk ][ drives ?

@skiphipdata
Copy link
Author

I like this, but I'm thinking it could be nice to have the full status display in non-2x windowed mode as well. Maybe you could try moving the drive status indicators to a row on the bottom on the window instead of on the side? It seems like the side bar is getting crowded and could benefit from being spread out horizontally.

Or maybe find a way to arrange them that would more closely resemble the way they would look with real hardware. If I had 4 drives connected to 2 controllers on a real Apple II, I'd probably stack them in a cube, like this, on the right side of the machine:

S5D1 S6D1
S5D2 S6D2

Other folks might arrange them differently, but back in the day the way I saw most people who had 2 drives arrange them was to have them stacked on the right side of the machine, with drive 1 on top and drive 2 on the bottom. I never knew anyone who had 2 controllers, but if I had that setup today, I'd arrange the drives like above so that their physical locations correspond to where they're physically connected inside the machine. Slot 5 is on the left, and Drive 1 is on top. Maybe it would make sense to arrange the virtual LEDs similarly for a 2-disk controller configuration?

@tomcw
Copy link
Contributor

tomcw commented Oct 23, 2022

@burniouf - using this small font, this is what the characters: ½, ¼ and ¾ look like.
IE. the image below is meant to display the following:

T 3½ T 0¼
S 6¾ S ??

image

Given the font size, I don't think those fractions are legible.

But since they are changing so quickly - do you care?

Other ideas (just focussing on the current UI layout for now)

  • have a mouse-over tooltip to show the full decimal track, eg. "T 3.75"
  • use a simple replacement character, eg. "a","b","c" to mean ".25",".5",".75", eg. "T 3c" to mean "T 3.75"
  • use a better glyph, eg. -,=,三, eg. "T 3三" to mean "T 3.75"
    • or 1/2/3 dots, eg, . : ⋮ , eg. "T 3⋮" to mean "T 3.75"

@sicklittlemonkey
Copy link
Contributor

Nice work Tom - I like the ability to simplify the display.
I think .25 etc is clearest, but in case you wanted other ideas, you could also use symbols.

Quarters of a block: ▘ , ▚ , and ▛ or ▜ .
There are also quarters of a circle: ◔ , ◑ , ◕ etc.

@burniouf
Copy link

i would use it for debugging, so i don't think you should spend that much time on visual effets or symbols.....
.00 .25 .50 .75 should be more helpful :-)

@tomcw
Copy link
Contributor

tomcw commented Oct 25, 2022

Thanks.

btw, you can already see quarter track (or half phase) info from the built-in debugger (F7), using disk i[nfo]:

image

(but currently only for slot-6's enabled drive; and only quarter track precision for .woz images)

@burniouf
Copy link

burniouf commented Oct 25, 2022

just read again above.....
your idea of "have a mouse-over tooltip to show the full decimal track, eg. "T 3.75" could be fine !
you may add in the tooltip T$00,25, ph0:on/off, ph1:on/off,ph2:on/off,ph3:on/off....bitOffset....etc...
"phase $42.50" has not a clear meaning, to my opinion, should be "halftrack $42.50", but in taht case, why not "QTrack $85"

@tomcw
Copy link
Contributor

tomcw commented Oct 25, 2022

Thanks @burniouf - I agree, a tooltip gives more scope for richer details and means I don't need to try to "shoehorn" more into the existing UI's tiny space.

@tomcw
Copy link
Contributor

tomcw commented Nov 3, 2022

I'm experimenting with:

  • Slot 5 Disk II LEDs are always visible (if Slot 5 card is diskii)
  • A UI toggle: used to switch between showing the track/sector info for both slots or no track/sector info (just show LEDs)
  • The tooltip (which is WIP) currently shows hex & dec track info for both drives
Show full track/sector info for all s6+s5 drives Just show LEDs
image image

@sicklittlemonkey
Copy link
Contributor

Looks good! My only requested change would be to add spaces, i.e. "Drive1" -> "Drive 1". ; - )

@burniouf
Copy link

burniouf commented Nov 4, 2022

Same for me, looks perfect! if you want to debug easily with Qtracks, just boot ProDOS.FX media and use a 192k formatted disk

@tomcw
Copy link
Contributor

tomcw commented Nov 4, 2022

Re-orientate, so that drive 1 (and drive 2) info is vertical - so it matches the GUI that the tooltip is for:

image

@tomcw
Copy link
Contributor

tomcw commented Nov 4, 2022

Again drive 1 (and drive 2) info is vertical - but this time with track's hex and dec on a single (longer line), and then sector's hex/dec on next line:

image

@tomcw
Copy link
Contributor

tomcw commented Nov 4, 2022

Probably this latter one is best?
btw, if we know it's a DOS (or ProDOS) disk, then we could also include the logical sector number too (or block number for ProDOS).
EDIT: it is showing the logical sector number (as read from the "magic" DOS/ProDOS memory locations)... so we could include the physical sector (after decoding the VTSC 4-and-4 address field nibbles).

tomcw added a commit that referenced this issue Nov 17, 2022
. In 2x windowed mode: always show slot 5 Disk II LEDs.
. Add tooltips for slot 5/6 track/sector info (d1 & d2) - shows dec/hex & fractional track position.
  - but this track/sector info is now on a UI toggle in the Config -> Disk tab.
. Debugger: add 'DISK SLOT n' - to set current slot of Disk II card
  - ie. support 'DISK INFO' for slot 5
@tomcw tomcw added this to the 1.30.13 milestone Nov 17, 2022
@Michaelangel007
Copy link
Contributor

Re-orientate, so that drive 1 (and drive 2) info is vertical - so it matches the GUI that the tooltip is for:

image

I like that both Hex and Dec values are shown!

Another option might be to drop the the T and S entirely for the hex display and just put the hex values on one line?

$11.00/F

@sicklittlemonkey
Copy link
Contributor

Slightly off topic: I don't think I ever saw hex used for the rational quarter track part, ie: $11.4 ... $11.8 ... $11.C.
It's a pity, as it's nice and compact.

@tomcw
Copy link
Contributor

tomcw commented Nov 22, 2022

Thanks for the further suggestions (and yes, a shame the hex fractional part didn't ever catch on).

In the end I've settled on this wide tooltip:

image

@tomcw
Copy link
Contributor

tomcw commented Nov 22, 2022

btw, I also extended the debugger to support DISK commands for Disk II cards in other slots:

Debugger: add 'DISK SLOT n' - to set current slot of Disk II card
  - ie. support 'DISK INFO' for slot 5

@medasaro
Copy link
Contributor

I, too, would very much like to have a display for fractional tracks. It is very useful when debugging why copy-protected .woz files won't work.

-Matthew D'Asaro

@tomcw
Copy link
Contributor

tomcw commented Jan 2, 2023

Released this in AppleWin 1.30.13.0, so closing this issue.

@tomcw tomcw closed this as completed Jan 2, 2023
@tingtron
Copy link

On some ProDOS disks
I am getting ?? in S when track T is getting updated.
Compared with a previous version of AppleWin this does not happen -- it always shows S as non-?? whenever T is updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants