[Request] Tell JEI about the extra areas AE GUIs draw #3922
Comments
|
Will be considered once there is time to refactor the whole GUI part to make these things easier. |
|
Sounds good. I was going to PR it myself but things got complicated, so I understand why you’d want to refactor first. |
|
@mezz Is this still relevant in 1.15? I think JEI now automatically inspects the current screen's size if I am not mistaken, or at least I don't see any obvious overlaps in 1.15 anymore. |
|
JEI works the same way, maybe AE is supplying different values in 1.15? |
|
I'll double check it again. |
|
FYI, Still seeing this in minecraft versions of 1.16. |
|
@mezz We're in the process of implementing this, but on tall terminals, we see the following effect:
Is the only way to fix this to move our toolbars down? This is with JEI 7.6.1.71 |
|
You're doing the right thing here, I think JEI is just acting poorly in this case. Once this is in, please open an issue with JEI and we can work out the rest of this on my side :) |
Completely refactor all UI. Introduce JSON based definitions for screens (can be overridden in resource packs). Unifies fluid and item terminal UI code. Serializes item data from server->client using "share tags" (i.e. don't include the content of bags if they support that), and no longer synchronize capability data to the client. Use "serial numbers" to refer back to items on the server when a player interacts with items in terminals. This should fix #5083 "for good" while still using less network bandwidth. It should also fix #5199 because serialization of items into packets is rewritten and now uses a length-prefix, reducing the chance for corrupted packets due to very long item NBT data. Rewrote crafting status / network status to use custom packets rather than reusing the inventory sync packets. Also implements #3787, #3922 Also adds: Start using share tags / stop sending caps to clients, which should reduce bandwidth usage when opening terminals Consider missing items on "shift-clickicking" recipes into the crafting terminal from JEI Adds tooltip indicating which upgrades are compatible to the upgrade panel for various machines Adds information on how priority works to the priority screen Use standard slots for the player inventory, which should fix most inventory sorting mods moving the hotbar into the main inventory when sorting the player inventory within an AE2 screen. Add clickable "show recipes" areas that open the appropriate JEI category to the inscriber and grindstone
|
This is now implemented in the 8.4 alpha |
Describe the feature
Currently, some AE guis overlap a bit with JEI because of the extras they have on the left and right sides.
There is no way to detect these automatically in JEI, but AE can use its JEI Plugin to do it.
In
appeng.integration.modules.jei.JEIPlugin#registercall
mezz.jei.api.IModRegistry#addAdvancedGuiHandlersand implement a
IAdvancedGuiHandlerfor your gui.mezz.jei.api.gui.IAdvancedGuiHandler#getGuiExtraAreasis the method that will tell JEI about extra slots on the sides of your gui so that JEI can move out of the way.To test fully, use the latest version of JEI and add some bookmarks to the left panel by hovering over items and pressing 'a'.
Reasons why it should be considered
It creates a more pleasing experience for players.
Additional Context
Here is the original issue reported to JEI: mezz/JustEnoughItems#1484
The text was updated successfully, but these errors were encountered: