Improve CraftGuide integration #1513
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NPE was causing CraftGuide to open *very* slowly. Tens of seconds vs ~1
| import net.minecraft.init.Blocks; | ||
| import net.minecraft.item.ItemStack; | ||
| import net.minecraft.item.crafting.CraftingManager; | ||
| import net.minecraft.item.crafting.IRecipe; | ||
|
|
There was a problem hiding this comment.
The blank lines between the import groups are intentional.
|
So this'll fix the huge load time? Finally! :D |
Changed grinderSlots and inscriberSlots to static fields, changed ExtraSlot to ItemSlot in them, as they didn't benefit from additional features of ExtraSlot, but it would otherwise require grinderSlots and inscriberSlots to not be static. Re-added blank line grouping imports (Eclipse must have automatically removed it earlier). Also removed two now-unused imports. Made aeBlocks final (I hope this was what was being referred to).
|
I send you a cleanup PR, then I can pull it. |
|
Hopefully this damn freeze gets fixed because half the AE2 recipes won't show anyways :l |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug had crept in that caused the CraftGuide to NPE once for each non-AE2 crafting recipe, extending CraftGuide recipe loading time by tens of seconds.
While doing that, I cleaned up the rest of the file by removing two unnessecary interface implementations, and added support for inscriber and grinder recipes.
I hope that I adequately imitated the code style of AE2.