Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CraftGuide integration #1513

Closed
wants to merge 3 commits into from
Closed

Improve CraftGuide integration #1513

wants to merge 3 commits into from

Conversation

@Uristqwerty
Copy link
Contributor

@Uristqwerty Uristqwerty commented May 26, 2015

A bug had crept in that caused the CraftGuide to NPE once for each non-AE2 crafting recipe, extending CraftGuide recipe loading time by tens of seconds.

While doing that, I cleaned up the rest of the file by removing two unnessecary interface implementations, and added support for inscriber and grinder recipes.

I hope that I adequately imitated the code style of AE2.

import net.minecraft.init.Blocks;
import net.minecraft.item.ItemStack;
import net.minecraft.item.crafting.CraftingManager;
import net.minecraft.item.crafting.IRecipe;

Copy link
Member

@yueh yueh May 27, 2015

The blank lines between the import groups are intentional.

@JackTheRedCreeper
Copy link

@JackTheRedCreeper JackTheRedCreeper commented May 29, 2015

So this'll fix the huge load time? Finally! :D

Changed grinderSlots and inscriberSlots to static fields, changed ExtraSlot
to ItemSlot in them, as they didn't benefit from additional features of
ExtraSlot, but it would otherwise require grinderSlots and inscriberSlots
to not be static.

Re-added blank line grouping imports (Eclipse must have automatically
removed it earlier). Also removed two now-unused imports.

Made aeBlocks final (I hope this was what was being referred to).
@thatsIch
Copy link
Member

@thatsIch thatsIch commented Jun 2, 2015

@Uristqwerty

I send you a cleanup PR,
you probably require a rebase before you can pull it,
squash that,

then I can pull it.

@JackTheRedCreeper
Copy link

@JackTheRedCreeper JackTheRedCreeper commented Jun 8, 2015

Hopefully this damn freeze gets fixed because half the AE2 recipes won't show anyways :l

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants