Removes coremod #3038
Removes coremod #3038
Conversation
From now on every integration must not rely on method stripping through a coremod or @optional. Notable example for a very good solution is IC2. As consequence this drops all support for RF and mods must support on of our supported energy types. At the time of writing, ForgeEnergy and IC2/EU.
| this.setInternalCurrentPower( this.getInternalCurrentPower() + amt ); | ||
| if( this.getInternalCurrentPower() > this.getInternalMaxPower() ) | ||
| { | ||
| amt = this.getInternalCurrentPower() - this.getInternalMaxPower(); |
There was a problem hiding this comment.
| } | ||
|
|
||
| @TileEvent( TileEventType.WORLD_NBT_WRITE ) | ||
| public void writeToNBT_AERootPoweredTile( final NBTTagCompound data ) |
There was a problem hiding this comment.
| return PowerUnits.AE.convertTo( externalUnit, Math.max( 0.0, this.getFunnelPowerDemand( externalUnit.convertTo( PowerUnits.AE, maxPowerRequired ) ) ) ); | ||
| } | ||
|
|
||
| protected double getFunnelPowerDemand( final double maxRequired ) |
There was a problem hiding this comment.
| return amt; | ||
| } | ||
|
|
||
| amt = this.getInternalCurrentPower(); |
There was a problem hiding this comment.
| } | ||
| else if( capability == Capabilities.TESLA_CONSUMER ) | ||
| { | ||
| if( this.getPowerSides().contains( facing ) ) |
There was a problem hiding this comment.
| } | ||
|
|
||
| @TileEvent( TileEventType.WORLD_NBT_READ ) | ||
| public void readFromNBT_AERootPoweredTile( final NBTTagCompound data ) |
There was a problem hiding this comment.
| } | ||
| } | ||
|
|
||
| protected void PowerEvent( final PowerEventType x ) |
There was a problem hiding this comment.
| } | ||
| else if( capability == Capabilities.TESLA_CONSUMER ) | ||
| { | ||
| if( this.getPowerSides().contains( facing ) ) |
There was a problem hiding this comment.
| @Override | ||
| public boolean hasCapability( Capability<?> capability, EnumFacing facing ) | ||
| { | ||
| if( capability == Capabilities.FORGE_ENERGY ) |
There was a problem hiding this comment.
| this.addNewAttunement( "thermalfoundation", TunnelType.RF_POWER ); | ||
| this.addNewAttunement( "thermaldynamics", TunnelType.FE_POWER ); | ||
| this.addNewAttunement( "thermalexpansion", TunnelType.FE_POWER ); | ||
| this.addNewAttunement( "thermalfoundation", TunnelType.FE_POWER ); | ||
| // TODO: Remove when confirmed that the official 1.12 version of EnderIO will support FE. |
There was a problem hiding this comment.
| // fluxduct | ||
| this.addNewAttunement( this.getModItem( "thermaldynamics", "duct_0", 5 ), TunnelType.RF_POWER ); // cryo-stabilized | ||
| // fluxduct | ||
| this.addNewAttunement( this.getModItem( "thermaldynamics", "duct_0", 0 ), TunnelType.FE_POWER ); |
There was a problem hiding this comment.
| // TODO: Remove when confirmed that the official 1.12 version of EnderIO will support FE. | ||
| this.addNewAttunement( "enderio", TunnelType.RF_POWER ); | ||
| this.addNewAttunement( "enderio", TunnelType.FE_POWER ); | ||
| // TODO: Remove when confirmed that the official 1.12 version of Mekanism will support FE. |
There was a problem hiding this comment.
| // TODO: Remove when confirmed that the official 1.12 version of Mekanism will support FE. | ||
| this.addNewAttunement( "mekanism", TunnelType.RF_POWER ); | ||
| this.addNewAttunement( "mekanism", TunnelType.FE_POWER ); | ||
| // TODO: Remove when support for RFTools' Powercells support is added |
There was a problem hiding this comment.
|
SonarQube analysis reported 35 issues
Watch the comments in this conversation to review them. Top 10 extra issuesNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
| return new RFModule(); | ||
| } | ||
| }, | ||
|
|
||
| MFR( IntegrationSide.BOTH, "Mine Factory Reloaded", "minefactoryreloaded" ), | ||
|
|
||
| Waila( IntegrationSide.BOTH, "Waila", "waila" ) |
There was a problem hiding this comment.
From now on every integration must not rely on method stripping through
a coremod or @optional. Notable example for a very good solution is IC2.
As consequence this drops all support for RF and mods must support on of
our supported energy types. At the time of writing, ForgeEnergy and
IC2/EU.