Rework fuzzy comparison for 99 percent threshold #3367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation is quite convoluted and can handle 99% incorrectly when items exceed a certain damage range.
yueh
force-pushed
the
rework-fuzzy-comparison
branch
from
27bfce1
to
46dd2b4
Compare
Some item could use metadata to pack damageable and undamageable items into the same id. Thus could lead to get ItemStack#getItemDamage() to return bogus values for undamageable items.
|
SonarQube analysis reported 2 issues Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation is quite convoluted and can handle 99%
incorrectly when items exceed a certain damage range.