Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format fluid tooltip in buckets #3580

Merged
merged 1 commit into from
Jul 4, 2018
Merged

Format fluid tooltip in buckets #3580

merged 1 commit into from
Jul 4, 2018

Conversation

fscan
Copy link
Member

@fscan fscan commented Jun 30, 2018

Fixes #3560

@orod-org
Copy link

SonarQube analysis reported 9 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. BLOCKER GuiFluidTerminal.java#: Add or update the header of this file. rule
  2. CRITICAL GuiFluidTerminal.java#L245: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  3. MAJOR GuiFluidTerminal.java#L76: Remove this unused "maxRows" private field. rule
  4. MAJOR GuiFluidTerminal.java#L95: Extract the assignment out of this expression. rule
  5. MAJOR GuiFluidTerminal.java#L114: Extract the assignment out of this expression. rule
  6. MAJOR GuiFluidTerminal.java#L117: Extract the assignment out of this expression. rule
  7. MINOR GuiFluidTerminal.java#L74: Make this final field static too. rule
  8. MINOR GuiFluidTerminal.java#L360: Remove this method and declare a constant for this value. rule
  9. INFO GuiFluidTerminal.java#L235: Complete the task associated to this TODO comment. rule

@yueh yueh added this to the rv6.alpha - 1.12 milestone Jul 1, 2018
@fscan fscan merged commit 3ba04b3 into rv6-1.12 Jul 4, 2018
@fscan fscan deleted the me-fluid-tooltip branch July 4, 2018 19:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ME Fluid Terminal numbers should be consistent with ME Terminal
3 participants