Skip to content

Commit

Permalink
Fix fail message construction in cc_shared_library
Browse files Browse the repository at this point in the history
Previously, if there were many unaccounted for libraries, this would simply fail with:
```
Error in join: 'string' is not iterable
```

Closes bazelbuild#14697.

PiperOrigin-RevId: 440090957
  • Loading branch information
fmeum authored and ankit-agarwal1999 committed May 12, 2022
1 parent 1ec2b57 commit 73d79dd
Showing 1 changed file with 1 addition and 1 deletion.
Expand Up @@ -351,7 +351,7 @@ def _throw_error_if_unaccounted_libs(unaccounted_for_libs):
libs_message.append(str(unaccounted_lib))

if len(unaccounted_for_libs) > 10:
libs_message = "(and " + str(len(unaccounted_for_libs) - 10) + " others)\n"
libs_message.append("(and " + str(len(unaccounted_for_libs) - 10) + " others)\n")

static_deps_message = []
for repo in different_repos:
Expand Down

0 comments on commit 73d79dd

Please sign in to comment.