Fix fail message construction in cc_shared_library #14697
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if there were many unaccounted for libraries, this would simply fail with: ``` Error in join: 'string' is not iterable ```
|
@oquenchil This is a one-line Starlark fix. |
|
Can we cherrypick this onto 5.1.1. It kind of blocks a core migration workflow (i.e analyzing unaccounted for deps) |
ankit-agarwal1999
pushed a commit
to AppliedIntuition/bazel
that referenced
this pull request
May 12, 2022
Previously, if there were many unaccounted for libraries, this would simply fail with: ``` Error in join: 'string' is not iterable ``` Closes bazelbuild#14697. PiperOrigin-RevId: 440090957
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
|
@bazel-io fork 5.3.0 |
bazel-io
removed
the
potential release blocker
ckolli5
added a commit
that referenced
this pull request
Jun 21, 2022
Previously, if there were many unaccounted for libraries, this would simply fail with: ``` Error in join: 'string' is not iterable ``` Closes #14697. PiperOrigin-RevId: 440090957 Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if there were many unaccounted for libraries, this would simply fail with: