-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract metric to own module #32
Conversation
- extract all result listener to own HealthListener interface
- remove empty default option logic - remove unused internal type
… race condition on the result map
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a few more ideas and suggestions, but overall 👍
Merging, cause the rest of the comments are either minor or controversial. |
Remove all metrics reporting from main module.
At the moment, we implement opencencus metrics reporting using the
CheckListener
solution.New API
HealthListener
to enable events when results are updatedCheckListener
sOption
API now supports registeringCheckListener
s andHealthListener
sBreaking Changes
OnCheckRegistered
toCheckListener
- this will enable actions when check is registered with the service. e.g. resetting metrics in opencencusDiscussion in #24