Skip to content

Commit

Permalink
Use box linters (#583)
Browse files Browse the repository at this point in the history
* placeholder for box.linters
* update rhino for use with box.linters
* delint for box.linters
* delint R source file
* delint e2e test file
* news update. delint rhino test files.
* force box.linters >= 0.9.1
* info about #' @import
* remove Linters section in pkgdown references
  • Loading branch information
radbasa committed Jun 5, 2024
1 parent 82476b5 commit d4d1bc7
Show file tree
Hide file tree
Showing 20 changed files with 32 additions and 1,208 deletions.
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: rhino
Title: A Framework for Enterprise Shiny Applications
Version: 1.7.0.9001
Version: 1.7.0.9002
Authors@R:
c(
person("Kamil", "Żyła", role = c("aut", "cre"), email = "opensource+kamil@appsilon.com"),
Expand All @@ -24,6 +24,7 @@ Depends:
R (>= 2.10)
Imports:
box (>= 1.1.3),
box.linters (>= 0.9.1),
cli,
config,
fs,
Expand All @@ -39,7 +40,6 @@ Imports:
testthat (>= 3.0.0),
utils,
withr,
xml2,
yaml
Suggests:
covr,
Expand Down
6 changes: 1 addition & 5 deletions NAMESPACE
Original file line number Diff line number Diff line change
@@ -1,11 +1,6 @@
# Generated by roxygen2: do not edit by hand

export(app)
export(box_alphabetical_calls_linter)
export(box_func_import_count_linter)
export(box_separate_calls_linter)
export(box_trailing_commas_linter)
export(box_universal_import_linter)
export(build_js)
export(build_sass)
export(diagnostics)
Expand All @@ -20,3 +15,4 @@ export(pkg_remove)
export(react_component)
export(test_e2e)
export(test_r)
import(box.linters)
5 changes: 4 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
# rhino (development version)

1. New `box_alphabetical_imports_linter` checks if all imports are alphabetically sorted.
1. All linter functions migrated to `box.linters`. New rhino projects will be configured to use linters from `box.linters`. To migrate an existing rhino project, run:
```r
box.linters::use_box_lintr(type = "rhino")
```
2. Update GitHub Workflow template triggers. To update your workflow run:
```r
file.copy(
Expand Down
Loading

0 comments on commit d4d1bc7

Please sign in to comment.