-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use box linters #583
Use box linters #583
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #583 +/- ##
===========================================
- Coverage 38.55% 20.65% -17.91%
===========================================
Files 10 9 -1
Lines 594 460 -134
===========================================
- Hits 229 95 -134
Misses 365 365 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, before merging please:
- remove "Linters" section from
_pkgdown.yml
- resolve my comment
Draft untilbox.linters
is released on CRAN.box.linters@0.9.0
releasedCloses #582
Description
rhino
app template.lintr
Definition of Done
R CMD check
, linter, unit tests, spelling)..Rd
files withroxygen2::roxygenise()
)