Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use box linters #583

Merged
merged 9 commits into from
Jun 5, 2024
Merged

Use box linters #583

merged 9 commits into from
Jun 5, 2024

Conversation

radbasa
Copy link
Contributor

@radbasa radbasa commented May 24, 2024

Draft until box.linters is released on CRAN. box.linters@0.9.0 released

Closes #582

Description

  • update rhino app template .lintr
  • removed linter functions and unit tests

Definition of Done

  • The change is thoroughly documented.
  • The CI passes (R CMD check, linter, unit tests, spelling).
  • Any generated files have been updated (e.g. .Rd files with roxygen2::roxygenise())

@radbasa radbasa marked this pull request as draft May 24, 2024 08:08
@radbasa radbasa changed the title [PENDING] Use box linters Use box linters May 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.65%. Comparing base (82476b5) to head (60cda16).

Current head 60cda16 differs from pull request most recent head 0e9d8b7

Please upload reports for the commit 0e9d8b7 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #583       +/-   ##
===========================================
- Coverage   38.55%   20.65%   -17.91%     
===========================================
  Files          10        9        -1     
  Lines         594      460      -134     
===========================================
- Hits          229       95      -134     
  Misses        365      365               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@radbasa radbasa marked this pull request as ready for review June 4, 2024 11:54
@radbasa radbasa requested a review from jakubnowicki June 4, 2024 11:55
Copy link
Member

@jakubnowicki jakubnowicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, before merging please:

  • remove "Linters" section from _pkgdown.yml
  • resolve my comment

R/linters.R Show resolved Hide resolved
@radbasa radbasa merged commit d4d1bc7 into main Jun 5, 2024
10 checks passed
@radbasa radbasa deleted the use-box-linters branch June 5, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement box.linters
3 participants