Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make configure_logger() work with missing config fields #254

Merged
merged 2 commits into from
Apr 21, 2022
Merged

fix: make configure_logger() work with missing config fields #254

merged 2 commits into from
Apr 21, 2022

Conversation

TymekDev
Copy link
Contributor

Changes

Closes #245

How to test

  1. Create a new Rhino app
  2. Delete or comment out a field in config.yml
  3. Try running the app

@TymekDev TymekDev requested a review from kamilzyla April 19, 2022 18:35
kamilzyla
kamilzyla approved these changes Apr 21, 2022
View reviewed changes
Copy link
Collaborator

@kamilzyla kamilzyla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Kudos for unit tests with mockery 💯

@kamilzyla kamilzyla merged commit 88ac15f into develop Apr 21, 2022
@kamilzyla kamilzyla deleted the fix/config-logger branch April 21, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilzyla kamilzyla kamilzyla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

configure_logger() fails if config fields are missing
3 participants
@TymekDev @kamilzyla @TymekAppsilon