Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR with multiple changes and improvements grouped together #343

Merged
merged 102 commits into from
Jul 2, 2024
Merged

PR with multiple changes and improvements grouped together #343

merged 102 commits into from
Jul 2, 2024

Conversation

joiskash
Copy link
Collaborator

@joiskash joiskash commented Apr 16, 2024 •
edited
Loading

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #192 #341 #304 #310 #311 #226

Description
Other changes that are included in this PR

  1. Priority for commands
  2. H264 reverse playback
  3. MMQ pacemaker
  4. Race conditions fixed between MMQ and decoder
  5. Abstract control module for pipeline control
  6. Thumbnail generator added

Alternative(s) considered

Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type

Type Choose one: (Bug fix and Feature)

Screenshots (if applicable)

Checklist

  • I have read the Contribution Guidelines
  • I have written Unit Tests
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach

Vinayak-YB and others added 22 commits September 8, 2023 17:51
@Vinayak-YB
NVR initial commit
54c27f9
Removed NVRControl Module, moving to apranvr
9cfc6da
Adding Pipeline.cpp changes
1e63c53
@Vinayak-YB
sprint-3 changes
a377dee
@venkat0907
typo change in rtsp
4d7e31f
Play/pause and golive working checkpoint
70bf9b9
@Vinayak-YB
Sprint-4 changes for ApraPipes
a4949a3
Thumnail generatormodule
6974742
@venkat0907
added ifdef condition in thumbnaillistgenerator
051d04a
Reverse play ApraPipes(zaki)
8b53e56
@venkat0907
H264DecoderNvCodecHelper changes
e1a7502
@mohammedzakikochargi
aprapipes sprint 6 changes
f35abe9
@Vinayak-YB
temp commit
90e549d
@Vinayak-YB
GTLGL working perfectly *
19efcd0
@Vinayak-YB
Reverse play fixes and gtkgl cleanup
356fd12
Resolved plyback jitteriness issue
05bd236
increased decoder buffered frames limit
d49127c
Resolved decoder race conditions
e87b541
mmq fps issue fix
ae9284f
@yashrajsapra
Updated CMake to link with brotli
648a734
@yashrajsapra
FIxed build issue
38edbb9 
Added GtkGlRenderer module
@yashrajsapra
Enabled some cuda test
d54b7c8
@joiskash joiskash mentioned this pull request Apr 16, 2024
Closed
3 tasks
joiskash
joiskash commented Apr 16, 2024
View reviewed changes
Copy link
Collaborator Author

@joiskash joiskash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review

base/include/Command.h Outdated Show resolved Hide resolved
base/include/stdafx.h Show resolved Hide resolved
data/app_ui.glade Outdated Show resolved Hide resolved
base/src/View.cpp Outdated Show resolved Hide resolved
base/src/MultimediaQueueXform.cpp Outdated Show resolved Hide resolved
base/src/MultimediaQueueXform.cpp Outdated Show resolved Hide resolved
base/src/MultimediaQueueXform.cpp Show resolved Hide resolved
base/src/MultimediaQueueXform.cpp Outdated Show resolved Hide resolved
base/src/MultimediaQueueXform.cpp Outdated Show resolved Hide resolved
base/src/MultimediaQueueXform.cpp Outdated Show resolved Hide resolved
yashrajsapra
yashrajsapra requested changes Apr 17, 2024
View reviewed changes
base/src/NvEglRenderer.cpp Show resolved Hide resolved
base/src/NvEglRenderer.cpp Show resolved Hide resolved
base/src/NvEglRenderer.cpp Show resolved Hide resolved
base/include/ThumbnailListGenerator.h Show resolved Hide resolved
base/include/BoundBuffer.h Outdated Show resolved Hide resolved
base/src/Background.cpp Outdated Show resolved Hide resolved
base/src/Model.cpp Outdated Show resolved Hide resolved
base/src/Module.cpp Show resolved Hide resolved
base/src/Module.cpp Outdated Show resolved Hide resolved
base/src/Mp4WriterSink.cpp Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

Test Results Linux-CudaT

  1 files  ±0    1 suites  ±0   11m 59s ⏱️ + 1m 29s
409 tests +1  249 ✅ + 8  160 💤  - 7  0 ❌ ±0 
249 runs  +8   89 ✅ +15  160 💤  - 7  0 ❌ ±0 

Results for commit fd4ace6. ± Comparison against base commit 221719b.

This pull request skips 7 and un-skips 15 tests. 
multimediaqueuexform_tests ‑ export_state
multimediaqueuexform_tests ‑ future_export
multimediaqueuexform_tests ‑ idle_state
multimediaqueuexform_tests ‑ nextQueue_full
multimediaqueuexform_tests ‑ prop_change
multimediaqueuexform_tests ‑ wait_state
multimediaqueuexform_tests ‑ wait_to_export_state

h264decoder_tests ‑ encoder_to_decoder
h264decoder_tests ‑ h264_to_yuv420
h264decoder_tests ‑ mp4reader_to_decoder_extSink
jpegdecodernvjpeg_tests ‑ color_yuv420_640x360
jpegdecodernvjpeg_tests ‑ mono_1920x960
jpegencodernvjpeg_tests ‑ mono_1920x1080
jpegencodernvjpeg_tests ‑ rgb_1280x720
jpegencodernvjpeg_tests ‑ yuv420_640x360
nv_mp4_file_tests ‑ h264EncoderNV_to_h264writer
nv_mp4_file_tests ‑ h264EncoderNV_to_h264writer_Chunktime
…

♻️ This comment has been updated with latest results.

=zaki and others added 20 commits June 5, 2024 11:40
Merged ApraNVR
28c2215
@mohammedzakikochargi
Removed flush logiv from decoder and fixed a syntax in mmq
2947998
@mohammedzakikochargi
Updated libmp4 port
583bc8b
@Vinayak-YB
CMakeList commented code fixed
241ef14
@Vinayak-YB
CmakeList vcpkg env variable refactor
2d2ec94
@kushaljain-apra
uncomment aprapipesut executable in CMakeLists
4842e5b
@Vinayak-YB
Adding cudnn as a vcpkg overlay port
e188527
@Vinayak-YB
CMakelist change to use cudnn from custom overlay port
925e266
@mohammedzakikochargi
resolved mereg conflicts and resolved queuecommand issues
db23ee7
@mohammedzakikochargi
removed comments
7dc1a7e
@mohammedzakikochargi
Resolved gtk link issues on arm64
e914732
@mohammedzakikochargi
changed gcc version to 8 for arm github build script
77df71e
@mohammedzakikochargi
Resolved issues in Mp4Reader regarding the gop changes being in abstr…
13053ca 
…act class
@mohammedzakikochargi
changed linux cuda gcc version to 8
385e604
@mohammedzakikochargi
Updated the gitgub worflow file of arm64
c81596c
@mohammedzakikochargi
changed build dir name for lin
c507abb
@mohammedzakikochargi
Updated the cmakelists and workflow file
0d2e3c4
@mohammedzakikochargi
updated cmakelists to include glibconfig.h
b558e07
added pkg config path as env in the cmakelist
114285a
Added pkg config path as env only for arm64
5eebdf4
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 28, 2024 •
edited
Loading

Test Results Linux_ARM64

  1 files    1 suites   11m 2s ⏱️
431 tests 259 ✅ 172 💤 0 ❌
259 runs   87 ✅ 172 💤 0 ❌

Results for commit fd4ace6.

♻️ This comment has been updated with latest results.

mraduldubey
mraduldubey previously approved these changes Jun 28, 2024
View reviewed changes
@mraduldubey mraduldubey merged commit 53157e2 into main Jul 2, 2024
17 of 19 checks passed
@mraduldubey mraduldubey deleted the ApraNVR_CommonBuild branch July 2, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashrajsapra yashrajsapra yashrajsapra requested changes

@mraduldubey mraduldubey mraduldubey left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GtkGl Renderer
8 participants
@joiskash @mraduldubey @yashrajsapra @Vinayak-YB @venkat0907 @mohammedzakikochargi @kjois @kushaljain-apra