No Recommended: Split recommended blogs sidebar preference #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, huh. Resolves #1285, apparently. |
AprilSylph
approved these changes
Feb 20, 2024
AprilSylph
added a commit
that referenced
this pull request
Mar 17, 2024
remove sentence about inherited preferences deleting the inherited-from storage key; no longer true as of #983
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really digging into the bag today I guess.
Description
This splits the No Recommended option to hide recommended blogs into two: one that works in the blog view modal and one that does everything else.
(Technically there are more than two types of recommended blog carousels—the one in the tagged page is different than the one beside the dashboard, and the one on the search page is actually a fourth kind that we don't even hit right now. Also there's one on the logged-out page that gets hit by the code for the tagged page at the moment. But a) treating them differently is a level of granularity that I'd say is somewhat silly; and b) I don't know if anyone really notices those anyway.
The big ones, IMO, are the dashboard one because it is immediately visible and takes up space we want for XKit sidebar elements, and the blog view modal one because without it there's often nothing at all there.)
Important note: this tweaks the code for inherited preferences so that the previous preference doesn't get auto-deleted. I would be fine with reverting that and having the blog view option here not inherit, too; users who dislike seeing the newly non-hidden element in the blog view modal will presumably find their way to the No Recommended preference pane on their own, right? And then maybe people will complain about the empty blog view modal sidebar less often, idk.
Resolves #605.
Testing steps
Inheritance:
npm startFunctionality: