Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Banana Growers blocking the Sumo's door #68

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

ryfactor
Copy link

@AquariusPower how about this? After sumo wrestling, it checks for all the banana growers on the level and sets their FeedingSumo flags to false, meaning they change their MovingTo target to the banana drop area during their GetAICommand().

The only thing is it requires static std::vector<character*> FindCharactersOnLevel() to become a public member of class bugfixdp. It's a pretty handy method, some of this stuff could really be generalized to the rest of the code. Could probably make it a method in level.cpp.

@AquariusPower
Copy link
Owner

AquariusPower commented Nov 25, 2021

I dont remember if the problem only happens after the sumo wrestling or before too.
I read the code and it looks good, but I couldnt test it yet as my environment here changed a lot, and I need to track down where everything is and also the backups :>
I see this is the same branch for the pull on the Attnam repo.
I will merge here so you can continue there.
Can i add you (and the others) here as maintainer? so that you can freely change things here to not block the pull requests on Attnam. I will check.

@AquariusPower AquariusPower merged commit 701cbd5 into AquariusPower:FixDungeonGen Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants