Suggested SimDenitrification modification #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MB, |
|
Ta!
Dr Michael Barry
Senior Principal Engineer
Adjunct Associate Professor, Southern Cross University
***@***.***<https://www.tuflow.com/>
TUFLOW Products<https://www.tuflow.com/products/> | TUFLOW Pricing<https://www.tuflow.com/pricing/> | TUFLOW Support<https://www.tuflow.com/support/> | TUFLOW Training<https://www.tuflow.com/training/> | LinkedIn<https://www.linkedin.com/groups/1908583/> | YouTube<https://www.youtube.com/channel/UCZuGrIP8ayOwC1ojmnZrgPg>
The Latest TUFLOW FV Release 2020.03 is now available: Release Notes<https://downloads.tuflow.com/TUFLOWFV/Release_Notes/TUFLOW_FV_Release_Notes_2020.pdf> | Downloads Page<https://www.tuflow.com/downloads/#tuflow_fv>
From: Matt Hipsey ***@***.***>
Sent: 23 March 2022 15:11
To: AquaticEcoDynamics/libaed-water ***@***.***>
Cc: Michael Barry ***@***.***>; Author ***@***.***>
Subject: [External] Re: [AquaticEcoDynamics/libaed-water] Suggested SimDenitrification modification (PR #57)
MB,
Just need to be careful here as aed_nitrogen is also participating in denitrification. The intent maybe that in this case ams is already being incremented in aed_nitrogen so doesn't need to be here.
I'll take a closer look
—
Reply to this email directly, view it on GitHub<#57 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWW5ACGG3CA6LFXHGVJHQ2LVBKRURANCNFSM5RJYR4OA>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
This email has been scanned for viruses and malware Mimecast Ltd.
|
|
MB - you are right, this DON mineralisation was getting lost if simDenitrification = 0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Matt
It may be that when SimDenitrification = 0, don_mineralisation mmol is removed from DON but not added to any other state variables. This causes mass balance issues on ammonium. Removing the single IF statement suggested in this pull request fixes this issue: denitrification is zero, but DON still mineralises to ammonium and is accounted for correctly.