-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sol v0.8 #47
Sol v0.8 #47
Conversation
fix nix path in CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
A few new additions building on https://github.com/Arachnid/solidity-stringutils/pull/45/files
Nice work! @Arachnid Can you please merge this pull request? This brings the library from the 0.4 to the 0.8 Solidity version, which is absolutely necessary. |
@RyanRHall I'm getting this warning in the hardhat console:
This is because the The code still works, nothing serious, but it would make sense to rename the |
Also adding EDIT: Nevermind, I see the repo already has a license (Apache v2), so this identifier should be added on top of the Solidity file: |
wen merge? |
thank you @Arachnid ! |
This PR does the following: