Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sol v0.8 #47

Merged
merged 7 commits into from
Mar 8, 2022
Merged

Sol v0.8 #47

merged 7 commits into from
Mar 8, 2022

Conversation

RyanRHall
Copy link
Contributor

This PR does the following:

  • upgrades the strings library to sol v0.8
  • updates the ds-test submodule to latest version (needed for the unlocked pragma)
  • adds a CI workflow (to hopefully make future changes easier)

Copy link

@zbcoding zbcoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tempe-techie
Copy link

Nice work!

@Arachnid Can you please merge this pull request? This brings the library from the 0.4 to the 0.8 Solidity version, which is absolutely necessary.

@tempe-techie
Copy link

@RyanRHall I'm getting this warning in the hardhat console:

Warning: This declaration shadows an existing declaration.

45 |     function memcpy(uint dest, uint src, uint len) private pure {

This is because the len attribute has the same name as the function len().

The code still works, nothing serious, but it would make sense to rename the len attribute in memcpy to _len or something else.

@tempe-techie
Copy link

tempe-techie commented Jan 4, 2022

Also adding SPDX-License-Identifier would be beneficial, but this is something @Arachnid needs to decide since he wrote the library.

EDIT: Nevermind, I see the repo already has a license (Apache v2), so this identifier should be added on top of the Solidity file: // SPDX-License-Identifier: Apache-2.0

@hellwolf
Copy link

hellwolf commented Mar 8, 2022

wen merge?

@Arachnid Arachnid merged commit 46983c6 into Arachnid:master Mar 8, 2022
@hellwolf
Copy link

hellwolf commented Mar 9, 2022

thank you @Arachnid !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants