Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

camera: action API support #468

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

camera: action API support #468

wants to merge 2 commits into from

Conversation

EmmanuelP
Copy link
Contributor

No description provided.

@EmmanuelP EmmanuelP changed the title Action API support WIP: Action API support Feb 26, 2021
Copy link
Contributor Author

@EmmanuelP EmmanuelP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not fond of the current API. It is too low level.

May be a better approach would be to configure the action with just giving a set of devices. We may be able to automatically define the needed keys, and have a *_full version with user given key values. I guess the broadcast address can be also found automatically, or set explicetely in the *_full API version.

Comment on lines +2764 to +2771
if (error == NULL)
arv_camera_set_string (camera, "ActionSelector", command_name, &local_error);
if (error == NULL)
arv_camera_set_integer (camera, "ActionDeviceKey", device_key, &local_error);
if (error == NULL)
arv_camera_set_integer (camera, "ActionGroupKey", group_key, &local_error);
if (error == NULL)
arv_camera_set_integer (camera, "ActionGroupMask", group_key, &local_error);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should test local_error, not error

Comment on lines +431 to +438
arv_gv_device_issue_scheduled_action_command (guint32 device_key, guint32 group_key, guint32 group_mask,
guint64 timestamp_ns, GInetAddress *broadcast_address,
GInetAddress **inet_addresses, guint *n_acknowledges,
GError **error)
{
return FALSE;
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: actual implementation

Comment on lines +83 to +87
gboolean arv_gv_device_issue_scheduled_action_command (guint32 device_key, guint32 group_key, guint32 group_mask,
guint64 timestamp_ns, GInetAddress *broadcast_address,
GInetAddress **inet_addresses, guint *n_acknowledges,
GError **error);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: actual implementation

Comment on lines +2801 to +2802
* @inet_addresses: (out): a placeholder for an array of acknowledge IP adresses
* @n_acknowledges: (out): a placeholder for the number of ackowledges
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API: we should handle devices by using #ArvDevice instances here, not by their IP addresses.

@EmmanuelP EmmanuelP marked this pull request as draft August 11, 2021 08:03
@EmmanuelP EmmanuelP changed the title WIP: Action API support camera: action API support Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants