Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handlers and views promotions from Arcbees. #127

Closed
wants to merge 2 commits into from

Conversation

branflake2267
Copy link
Contributor

No description provided.

@buildhive
Copy link

ArcBees » GWTP #215 FAILURE
Looks like there's a problem with this pull request
(what's this?)

@branflake2267
Copy link
Contributor Author

#2

@buildhive
Copy link

ArcBees » GWTP #216 SUCCESS
This pull request looks good
(what's this?)

@christiangoudreau
Copy link
Member

Let simon pierre finish that, we want to get rid of UiHandlerStrategy which is over engineered

@@ -190,7 +190,7 @@
<build-helper-maven-plugin.version>1.7</build-helper-maven-plugin.version>
<gwt-maven-plugin.version>2.5.0</gwt-maven-plugin.version>
<lifecycle-mapping-plugin.version>1.0.0</lifecycle-mapping-plugin.version>
<maven-checkstyle-plugin.version>2.7</maven-checkstyle-plugin.version>
<!-- <maven-checkstyle-plugin.version>2.7</maven-checkstyle-plugin.version> TODO Remove?-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha, checkstyle must stay active.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol. Yeah, checkstyle has to be fixed in several so it will build. :)

@branflake2267
Copy link
Contributor Author

Closing branch for now. I let it hang around in the branches for a while longer before deleting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants