Fixed NPE in Ofy DAO #299
Merged
Fixed NPE in Ofy DAO #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice job |
|
Well do it :D LGTM |
|
|
||
| @Override | ||
| public Ofy begin() { | ||
| return new Ofy(OfyService.ofy()); |
There was a problem hiding this comment.
com.gwtplatform.crawlerservice.server.objectify.OfyService is not used anymore execpt for the static constructor
There was a problem hiding this comment.
We should maybe remove it then
|
@Chris-V did you updated hivecrawl? |
|
No I'll do it this afternoon. I thought I just had view permissions. |
hpehl
pushed a commit
to hpehl/GWTP
that referenced
this pull request
Dec 9, 2014
Fixed NPE in Ofy DAO Former-commit-id: 8dbfeb9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix for a NPE in the BaseDao. We should add a story for some end-to-end and unit tests for the crawler in our next iteration.
We should also update our hivecrawl instance...