Builder pattern for DefaultModule #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Chris-V @christiangoudreau @jbarop Is that what you had in mind? |
| * @param placeManagerClass The {@link PlaceManager} implementation. | ||
| * @param tokenFormatterClass The {@link TokenFormatter} implementation. | ||
| */ | ||
| public DefaultModule(Class<? extends PlaceManager> placeManagerClass, |
There was a problem hiding this comment.
This should still be available but market as deprecated for backward compatibility
|
one small nit |
|
Nit fixed. |
|
LGTM |
olafleur
added a commit
that referenced
this pull request
May 1, 2014
Builder pattern for DefaultModule
|
Now that we have a builder pattern, having some sugar to configure the default places would be nice ;) ie: install(new DefaultModule.Builder()
.defaultPlace(NameTokens.HOME)
.errorPlace(NameTokens.HALP_ME)
.build()); |
|
@Chris-V should we create an issue with a clear description of that feature? |
|
Yes |
|
Created #483 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix #184 .