Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small cleanup #730

Merged
merged 9 commits into from
Sep 21, 2015
Merged

Small cleanup #730

merged 9 commits into from
Sep 21, 2015

Conversation

olafleur
Copy link
Member

@olafleur olafleur commented Sep 7, 2015

No description provided.

@@ -29,7 +29,7 @@
public class CookieParamValueResolverTest {
private static final String SOME_VALUE = "llamas";

private CookieParamValueResolver resolver = new CookieParamValueResolver();
private final CookieParamValueResolver resolver = new CookieParamValueResolver();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We never made anything final beside constants in Test classes, but whatever. That's funny

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you prefer that I remove it? IntelliJ was telling me that it could be final. ;-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't bother. I just actually don't care whether test fields are final or not, but might as well keep it now ;)

@@ -4,4 +4,5 @@

<module>
<source path="shared"/>
<source path="client"/>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chris-V I guess I should remove that one too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@olafleur
Copy link
Member Author

@Chris-V LGTM?

@Chris-V
Copy link
Member

Chris-V commented Sep 21, 2015

LGTM (still remove the other client source path please :)

olafleur pushed a commit that referenced this pull request Sep 21, 2015
@olafleur olafleur merged commit 6c920bd into master Sep 21, 2015
@olafleur olafleur deleted the ol_small_cleanup branch February 1, 2016 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants