Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samples #21

Merged
merged 7 commits into from
Jun 13, 2013
Merged

Samples #21

merged 7 commits into from
Jun 13, 2013

Conversation

przemekgalazka
Copy link
Member

No description provided.

@buildhive
Copy link

ArcBees » Jukito #59 SUCCESS
This pull request looks good
(what's this?)

@@ -25,5 +29,6 @@
<version>${project.version}</version>
<scope>test</scope>
</dependency>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rm 32

@christiangoudreau
Copy link
Member

General code style comments:
No empty line at beginning of class unless the first line is on more then one line.
No empty line at end of class

No author information, its already being taken care by the DVCS.

Do you have an error if you write down ArcBees 2013? If yes we will need to update the checkstyle script to our latest

// Given
// When
// Then

@buildhive
Copy link

ArcBees » Jukito #60 SUCCESS
This pull request looks good
(what's this?)

@przemekgalazka
Copy link
Member Author

good to go ?

public Engine getEngine() {
return engine;
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing new line at end of file

@buildhive
Copy link

ArcBees » Jukito #63 SUCCESS
This pull request looks good
(what's this?)

@christiangoudreau
Copy link
Member

LGTM! Merging :D

christiangoudreau added a commit that referenced this pull request Jun 13, 2013
@christiangoudreau christiangoudreau merged commit 3d6634f into ArcBees:master Jun 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants