Fixed issue #30 #56
Fixed issue #30 #56
Conversation
Fetch from upstream
Added a test case to verify that the behavior still works properly for static inner classes.
|
Well, apparently http://stackoverflow.com/a/7189981/1768232 isn't actually true |
|
Build issue is linked to checkstyle |
|
I copied the license from a different class and it's still failing. |
| @@ -0,0 +1,87 @@ | |||
| /** | |||
| * Copyright 2013 ArcBees Inc. | |||
There was a problem hiding this comment.
2014 (Always inception year of the file)
Added contributors section to pom
| * @param klass | ||
| */ | ||
| @Test(expected = ConfigurationException.class) | ||
| public void testInnerClass(InnerClass klass) { |
There was a problem hiding this comment.
I don't think you need to add javadoc on every method. Is it sending you an error because of that?
There was a problem hiding this comment.
I just saw a lot of javadoc errors on one of the builds and it was easier for me to add javadoc than to figure out which line numbers were which because I had deleted and moved stuff around.
I still haven't managed to get checkstyle to work on my local machine, so better to be safe than sorry. Feel free to modify the pull request on the way in if you like
There was a problem hiding this comment.
That's fine, more is better than not enough :D
|
LGTM! Merging |
|
ArcBees » Jukito #144 SUCCESS |
Added an extra conditional to prevent using MockProvider if it's an inner class, and added a test to verify that the new version works correctly. This fixes issue #30